Skip to content

fix: increase proposal review period duration to 96 hours #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: increase proposal review period duration to 96 hours #129

wants to merge 1 commit into from

Conversation

ilbertt
Copy link
Member

@ilbertt ilbertt commented Mar 9, 2025 •
edited
Loading

As we discussed internally, it makes more sense now to increase the review period to 96 hours for now.

DONE:

  • Refactored the canister code to introduce the PROPOSAL_REVIEW_PERIOD_DURATION constant
  • Updated and improved tests for pending proposals

@ilbertt ilbertt requested a review from nathanosdev as a code owner March 9, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanosdev nathanosdev Awaiting requested review from nathanosdev nathanosdev is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ilbertt