Trustlab: Showcase block #1181
Open
Trustlab: Showcase block #1181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, and description; update padding and layout for improved responsiveness. Add Jest snapshot for ShowCase component.
kilemensi
reviewed
Jun 5, 2025
| import { Box, Button } from "@mui/material"; | ||
| import React from "react"; | ||
|
|
||
| function ShowCase({ |
There was a problem hiding this comment.
I don't think this is Showcase (one word) component... The goal isn't to showcase the images and content. I think it's more of a call to action i.e. calling attention to the incubator or security course on academy.AFRICA.
Comment on lines
+20
to
+29
| <Section | ||
| sx={{ | ||
| maxWidth: { md: "100%", xs: "100%" }, | ||
| bgcolor: "common.black", | ||
| color: "common.white", | ||
| py: 8, | ||
| }} | ||
| fixed={false} | ||
| > | ||
| <Box |
Comment on lines
+12
to
+15
| richText({ | ||
| name: "title", | ||
| required: true, | ||
| }), |
There was a problem hiding this comment.
Are titles actually rich text?
Comment on lines
+26
to
+30
| options: [ | ||
| { label: "Left to Right", value: "ltr" }, | ||
| { label: "Right to Left", value: "rtl" }, | ||
| ], | ||
| defaultValue: "ltr", |
There was a problem hiding this comment.
rtl could mean we're writing Arabic now 😄. May be we should have order (I think Grid has something similar) i.e. images first vs content first
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an image showcase and content
Fixes # (issue)
Type of change
Please delete options that are not relevant.
functionality to not work as expected)
Screenshots
Checklist: