Skip to content

NSBeep On Empty Undo, Remove Unnecessary Redirection #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

NSBeep On Empty Undo, Remove Unnecessary Redirection #102

wants to merge 1 commit into from

Conversation

thecoolwinter
Copy link
Contributor

Description

  • When the undo or redo stack is empty, and the user tries to undo or redo, plays the beep sound.
  • Removes the (now) unnecessary DelegatedUndoManager type that sent messages to the CEUndoManager type. This was a holdover from when we did not have a custom text view.
    • Made CEUndoManager a subclass of UndoManager
    • Added more overrides to more correctly conform to the UndoManager class.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austincondiff austincondiff Awaiting requested review from austincondiff

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨ Feedback when undo or redo stack is empty
1 participant
@thecoolwinter