# add-Toast #47
# add-Toast #47
Conversation
Codecov Report
@@ Coverage Diff @@
## master #47 +/- ##
==========================================
+ Coverage 98.6% 98.63% +0.02%
==========================================
Files 49 50 +1
Lines 430 439 +9
==========================================
+ Hits 424 433 +9
Misses 6 6
Continue to review full report at Codecov.
|
|
Needs some changes:
it('Should render a span tag by default', () => {
const wrapper = shallow(<Toast />)
expect(wrapper.type()).toBe('div')
})
Remove these unexpected changes. |
package.json
Outdated
| @@ -63,7 +63,6 @@ | |||
| "@storybook/node-logger": "^3.4.10", | |||
| "@storybook/react": "^3.4.10", | |||
| "@storybook/storybook-deployer": "^2.3.0", | |||
| "@types/classnames": "^2.2.6", | |||
There was a problem hiding this comment.
Package.json should not be changed
| @@ -1,4 +1,4 @@ | |||
| # title-component | |||
| # add-Toast | |||
There was a problem hiding this comment.
PULL_REQUEST_TEMPLATE.md should not be changed
| @@ -17,7 +17,7 @@ describe('Toasts', () => { | |||
| }) | |||
|
|
|||
| it('Should pass additional classNames', () => { | |||
| const wrapper = shallow(<Toast className='extra'>My Toasts</Toast>) | |||
| const wrapper = shallow(<Toast className="extra">My Toasts</Toast>) | |||
There was a problem hiding this comment.
Inconsistent quotes here. Use single quotes, follow the StandardJS style, run npm run lint to check for errors or use the extension.
| const classNames = classnames( | ||
| { | ||
| [`toast-${color}`]: color, | ||
| toast: 'toast' |
There was a problem hiding this comment.
Static classnames should not be inside the object for classnames().
src/__test__/Toast/Toast.test.js
Outdated
| expect(wrapper).toMatchSnapshot() | ||
| }) | ||
|
|
||
| // it('Should have Toasts classname', () => { |
| <Container> | ||
| <Row> | ||
| <Col all={3}> | ||
| <Toast className="m-2"> |
There was a problem hiding this comment.
Inconsistent quotes, needs to follow the StandardJS style guidelines using single quotes.
Types of changes