netlink: Fix NL_OP_COUNT definition, add debug for CHANGE_NAME #121
+8
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 1b6c367 ("mctp-netlink: add MCTP_NL_CHANGE_NAME event") did not update the COUNT definition, so causing a potential array index overrun on change dump. Instead of hard-coding, use the enum itself for the count value, and add a dump string for the new CHANGE_NAME event type. Fixes: 1b6c367 ("mctp-netlink: add MCTP_NL_CHANGE_NAME event") Fixes: CodeConstruct#120 Reported-by: Nidhin MS <[email protected]> Signed-off-by: Jeremy Kerr <[email protected]>
jk-ozlabs
force-pushed
the
dev/change-op-fix
branch
from
777250a to
3506e7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 1b6c367 ("mctp-netlink: add MCTP_NL_CHANGE_NAME event") did not update the COUNT definition, so causing a potential array index overrun on change dump.
Instead of hard-coding, use the enum itself for the count value, and add a dump string for the new CHANGE_NAME event type.
Fixes: 1b6c367 ("mctp-netlink: add MCTP_NL_CHANGE_NAME event")
Fixes: #120
Reported-by: Nidhin MS [email protected]