Async contact info collect for reviewer #109
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e number updates.
…survey controller.
rymaju
reviewed
Apr 22, 2023
| phone: phoneNumber, | ||
| }; | ||
| // TODO: Send email and phone number to the backend | ||
| await apiClient.updateReviewer(updateReviewer); |
There was a problem hiding this comment.
Is there a handler for if this API call fails? If not, should there be?
There was a problem hiding this comment.
i dont think there is a handler. @onb6 should i add a try catch that shows an alert if the api call failed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes https://app.clickup.com/t/863g4edcm
📝 Description
Briefly list the changes made to the code:
✔️ Verification
Verified that it works locally.
Provide screenshots of any new components, styling changes, or pages.