CLI: run servicedirectory command
#98
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asimpleidea
changed the title
run servicedirectory commandrun servicedirectory command
asimpleidea
force-pushed
the
cli/service-directory
branch
from
8d3fbda to
a2bd48d
Compare
asimpleidea
force-pushed
the
cli/service-directory
branch
from
a2bd48d to
8725039
Compare
asimpleidea
force-pushed
the
cli/service-directory
branch
5 times, most recently
from
10df928 to
bced905
Compare
This commit creates the foundations of the new CLI, introducing the root command and the `run` command. This latter one will be used to to run the program and will have many sub-commands, which will be added in next commits. Signed-off-by: Elis Lulja <[email protected]>
The `run` function executes the program as it used to, but is now oblivious of the service registry you choose. Signed-off-by: Elis Lulja <[email protected]>
This commit moves code to get files from a path or a configmap/secret to separate functions or utility functions.
This commit enables the operator to run with Google Service Directory. This command is not enabled yet, and will be once all others will be completed as well. Signed-off-by: Elis Lulja <[email protected]>
Network auto detection in GKE was not working due to deprecated API. This commit updates the code by using the new ones. Signed-off-by: Elis Lulja <[email protected]>
This commit allows the `run servicedirectory` command to start the program and register services on Service Directory by using the `run` function. Signed-off-by: Elis Lulja <[email protected]>
asimpleidea
force-pushed
the
cli/service-directory
branch
from
bced905 to
d0880ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues the effort on adding a powerful CLI to the operator and depends on #74.
It allows the operator to run and register its resources on Google Service Directory as it always did, but this time it can just be done as
cnwan-operator run servicedirectory [FLAGS]-- other aliases are also provided.TODOs:
runcommandOther todos coming.