Skip to content

Conversation

@supergary10
Copy link

No description provided.

@supergary10 supergary10 requested a review from baljit92 January 24, 2025 20:34
- name: DEBUG_SOCKET_DIR
value: /tmp/klog-socks
imagePullPolicy: {{ .Values.basic.image_pull_policy }}
imagePullPolicy: Never

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be Never? Can you double-check?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used the value from the update_1.8 commit at 22809e2#diff-317373f0dc2ee312347cf7e2cce9683f6fc278af96ec2135164c9c0547fb7f06R164.

According to https://kubernetes.io/docs/concepts/containers/images/#image-pull-policy, I believe setting this value to Never tells Kubelet to never fetch a remote image but only uses local ones. This should be intended for our project.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure? scheduler is the image that's always updated, right?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we update scheduler-image locally (with docker build) each time we run a submission. After the image is successfully built we run helm upgrade to deploy it.

ImagePullPolicy=Never ensures that during scheduler container creation with helm, we are only looking for a local image (named and tagged sailimages/vc-sail-scheduler:v3) instead of fetching from any remote image registry.

@xuyehe xuyehe merged commit 90b7158 into CloudComputingCourse:s25-1.10 Feb 6, 2025
1 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants