Skip to content

adding placeholder jars #2635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2025
Merged

adding placeholder jars #2635

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 41 additions & 1 deletion packages/clickhouse-jdbc-all/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,46 @@
</archive>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
<version>3.3.0</version> <!-- Use a recent version -->
<executions>
<execution>
<id>javadoc-jar</id>
<phase>package</phase>
<goals>
<goal>jar</goal>
</goals>
<configuration>
<classifier>javadoc</classifier>
<!-- To create an empty Javadoc JAR, you can set includeEmptyDirs to false and ensure no files are copied -->
<includeEmptyDirs>false</includeEmptyDirs>
<excludes>
<!-- Exclude all files to ensure an empty JAR if desired -->
<exclude>**/*</exclude>
</excludes>
</configuration>
</execution>
</executions>
</plugin>
Comment on lines +40 to +62
Copy link

@windsurf-bot windsurf-bot bot Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two separate maven-jar-plugin declarations which could lead to unexpected behavior. Consider merging them by moving the javadoc-jar execution into the first maven-jar-plugin declaration.

<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-source-plugin</artifactId>
Comment on lines +63 to +65
Copy link

@windsurf-bot windsurf-bot bot Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The maven-source-plugin is missing a version specification. It's a best practice to explicitly define plugin versions to ensure build reproducibility.

<configuration>
<excludes>
<exclude>**/*</exclude>
</excludes>
</configuration>
<executions>
<execution>
<id>attach-sources</id>
<goals>
<goal>jar</goal>
</goals>
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
Expand All @@ -51,7 +91,7 @@
<configuration>
<shadedArtifactAttached>false</shadedArtifactAttached>
<createDependencyReducedPom>true</createDependencyReducedPom>
<createSourcesJar>true</createSourcesJar>
<createSourcesJar>false</createSourcesJar>
<promoteTransitiveDependencies>true</promoteTransitiveDependencies>
<shadedClassifierName></shadedClassifierName>
</configuration>
Expand Down
Loading