Skip to content

Stress balance free drift model #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 84 commits into
base: main
Choose a base branch
from
Open

Conversation

simone-silvestri
Copy link
Collaborator

@simone-silvestri simone-silvestri commented May 22, 2025

This PR adds a stress balance free drift calculation that computes the velocity as a balance between the atmospheric stress at the top and the ocean stress at the bottom.

This addition warrants the change of the module name from SeaIceMomentumEquations to SeaIceDynamics since SeaIceMomentumEquation becomes only one of the dynamics model that we can use

Copy link

codecov bot commented May 22, 2025

Codecov Report

Attention: Patch coverage is 54.00000% with 23 lines in your changes missing coverage. Please review.

Project coverage is 69.24%. Comparing base (a922f71) to head (0669e43).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/SeaIceDynamics/stress_balance_free_drift.jl 47.22% 19 Missing ⚠️
src/Rheologies/Rheologies.jl 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
- Coverage   70.44%   69.24%   -1.20%     
==========================================
  Files          27       28       +1     
  Lines         829      865      +36     
==========================================
+ Hits          584      599      +15     
- Misses        245      266      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

and an explicit part ``τaˣ = τaˣₑ + u * τaˣᵢ`` and ``τoˣ = τoˣₑ + u * τoˣᵢ`` (and similarly for the y-component) such that
```
uᶠ = (τoˣₑ - τaˣₑ) / (τoˣᵢ - τaˣᵢ)
vᶠ = (τoʸₑ - τaʸₑ) / (τoʸᵢ - τaʸᵢ)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The units don't work here


A free drift parameterization that computes the free drift velocities as a balance between
top and bottom stresses ``τa ≈ τo`` where we split the stresses into a linear implicit part
and an explicit part ``τaˣ = τaˣₑ + u * τaˣᵢ`` and ``τoˣ = τoˣₑ + u * τoˣᵢ`` (and similarly for the y-component) such that
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the units don't make sense.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

τ has units m^2 / s^2, u is m/s, and so if you want something of the form τ = something * u, then something has units m/s --- its a velocity.

Is that what you want? Not a quadratic term?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, I will change the docs and the names in the code to make sure it is more understandable.
I am not sure this is necessarily what we want, this is how we treat the stress in the SeaIceMomentumEquations (semi-implicitly), but maybe here we can treat it quadratically. I ll need to add a couple more methods.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably need to solve a nonlinear system of equations if we want the whole implicit quadratic drag

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be simpler if one of the two stresses does not depend on the ice velocity, so that we can write an explicit formula. I ll add a method for when the top stress is independent on the ice velocity and when the bottom stress is independent of the ice velocity. We can leave the case in which both stresses are implicit for which we need a non-linear solve for the future.

@simone-silvestri
Copy link
Collaborator Author

An example of the ice_advected_by_anticyclone.jl using

dynamics = StressBalanceFreeDrift(top_stress, bottom_stress)
sea_ice_advected_by_anticyclone.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants