-
Notifications
You must be signed in to change notification settings - Fork 18
OMIP prototype #456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
OMIP prototype #456
Conversation
…to ss/omip-prototype
…to ss/omip-prototype
…to ss/omip-prototype
using ClimaOcean.JRA55 | ||
using ClimaOcean.DataWrangling: download_dataset | ||
|
||
atmosphere = JRA55PrescribedAtmosphere(; dir="forcing_data/", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying to encourage people not to set this variable because it makes setups less portable (eg data will be re-downloaded everywhere)
clock1.last_Δt = clock2.last_Δt | ||
end | ||
|
||
synch!(model1, model2) = synch!(model1.clock, model2.clock) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you need this please put it in a separate PR and get that merged, because people want to use stuff
closure = (ClimaOcean.OceanSimulations.default_ocean_closure(), | ||
VerticalScalarDiffusivity(κ=1e-5, ν=1e-5)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
closure = (ClimaOcean.OceanSimulations.default_ocean_closure(), | |
VerticalScalarDiffusivity(κ=1e-5, ν=1e-5)) | |
closure = ClimaOcean.OceanSimulations.default_ocean_closure() |
CATKE has an effective background diffusivity through its minimum TKE. We should not add any additional mixing. If you need more, you can set the minimum TKE parameter in CATKE.
A PR that will introduce the pieces of an OMIP prototype. requires #437 and #453