Skip to content

OMIP prototype #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 138 commits into
base: main
Choose a base branch
from
Draft

OMIP prototype #456

wants to merge 138 commits into from

Conversation

simone-silvestri
Copy link
Collaborator

@simone-silvestri simone-silvestri commented Apr 3, 2025

A PR that will introduce the pieces of an OMIP prototype. requires #437 and #453

using ClimaOcean.JRA55
using ClimaOcean.DataWrangling: download_dataset

atmosphere = JRA55PrescribedAtmosphere(; dir="forcing_data/",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to encourage people not to set this variable because it makes setups less portable (eg data will be re-downloaded everywhere)

clock1.last_Δt = clock2.last_Δt
end

synch!(model1, model2) = synch!(model1.clock, model2.clock)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you need this please put it in a separate PR and get that merged, because people want to use stuff

Comment on lines 50 to 51
closure = (ClimaOcean.OceanSimulations.default_ocean_closure(),
VerticalScalarDiffusivity(κ=1e-5, ν=1e-5))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
closure = (ClimaOcean.OceanSimulations.default_ocean_closure(),
VerticalScalarDiffusivity=1e-5, ν=1e-5))
closure = ClimaOcean.OceanSimulations.default_ocean_closure()

CATKE has an effective background diffusivity through its minimum TKE. We should not add any additional mixing. If you need more, you can set the minimum TKE parameter in CATKE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants