OMIP prototype #456
Draft
OMIP prototype #456
+215
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to ss/omip-prototype
…to ss/omip-prototype
…to ss/omip-prototype
glwagner
reviewed
Apr 12, 2025
| using ClimaOcean.JRA55 | ||
| using ClimaOcean.DataWrangling: download_dataset | ||
|
|
||
| atmosphere = JRA55PrescribedAtmosphere(; dir="forcing_data/", |
There was a problem hiding this comment.
Trying to encourage people not to set this variable because it makes setups less portable (eg data will be re-downloaded everywhere)
glwagner
reviewed
Apr 12, 2025
| clock1.last_Δt = clock2.last_Δt | ||
| end | ||
|
|
||
| synch!(model1, model2) = synch!(model1.clock, model2.clock) |
There was a problem hiding this comment.
if you need this please put it in a separate PR and get that merged, because people want to use stuff
glwagner
reviewed
Apr 12, 2025
Comment on lines
50
to
51
| closure = (ClimaOcean.OceanSimulations.default_ocean_closure(), | ||
| VerticalScalarDiffusivity(κ=1e-5, ν=1e-5)) |
There was a problem hiding this comment.
Suggested change
| closure = (ClimaOcean.OceanSimulations.default_ocean_closure(), | |
| VerticalScalarDiffusivity(κ=1e-5, ν=1e-5)) | |
| closure = ClimaOcean.OceanSimulations.default_ocean_closure() |
CATKE has an effective background diffusivity through its minimum TKE. We should not add any additional mixing. If you need more, you can set the minimum TKE parameter in CATKE.
glwagner
reviewed
Apr 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A PR that will introduce the pieces of an OMIP prototype. requires #437 and #453