Skip to content

Bugfix: time_step!(model, dt) #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 13, 2025
Merged

Bugfix: time_step!(model, dt) #410

merged 2 commits into from
Mar 13, 2025

Conversation

glwagner
Copy link
Member

@glwagner glwagner commented Mar 13, 2025

possibly this closes #404

@glwagner glwagner changed the title Update time_step_ocean_sea_ice_model.jl Bugfix: time_step!(model, dt) Mar 13, 2025
@navidcy navidcy requested a review from taimoorsohail March 13, 2025 04:00
@navidcy navidcy added the bug Something isn't working label Mar 13, 2025
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simone-silvestri this test was never called so we deleted it; if it's important for some reason we can add it again. Just tagging you here in case you are wondering in the future where did this go...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no problem, I guess the parameter space is checked in the GPU version of test_ocean_sea_ice_model.jl

Copy link

codecov bot commented Mar 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (c7ce952) to head (e404e9e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...OceanSeaIceModels/time_step_ocean_sea_ice_model.jl 0.00% 2 Missing ⚠️
src/OceanSimulations/ocean_simulation.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #410   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         40      40           
  Lines       2288    2289    +1     
=====================================
- Misses      2288    2289    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@glwagner glwagner merged commit efc5477 into main Mar 13, 2025
20 checks passed
@glwagner glwagner deleted the glwagner-patch-1 branch March 13, 2025 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output writers seems not saving anything?
4 participants