-
Notifications
You must be signed in to change notification settings - Fork 18
New regional example for the ACC #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The error that I get is copied below.
|
what if you use the CPU and start julia with |
Thanks @simone-silvestri for the suggestion. Will try it now. |
Things go a lot further but there is a problem with the lines that defines It seems this is with
|
@simone-silvestri , any advice on what is going wrong here? |
It looks like there is a bug in the |
Thanks @simone-silvestri , I will give that a try! |
Make changes so that it runs
@simone-silvestri : I tried it and it seems like a function is not defined. I added this at the beginning and now it seems to be running!
|
Ah nice. I think we can export that type. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #142 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 34 34
Lines 1962 1983 +21
=====================================
- Misses 1962 1983 +21 ☔ View full report in Codecov by Sentry. |
It's running on a CPU (i.e. slow) and still on the initial time step. I made all these changes on the branch and can revert back to what we had previously as other fixes come along. Maybe I'll have something to share tomorrow. |
I started the job yesterday and it hasn't updated the output files in over 24 hours. I think something has gone wrong. Below is the currently display that I have. It hasn't stopped and still running on a CPU. Maybe we need to try it on a GPU or have more output to see what has gone wrong? Any suggestions?
|
My correction. It is still running on one CPU. It is at 4 days after 7 days of computing. Not a great ratio. What needs to be done so we need to do to run this on a GPU? @simone-silvestri |
Wow, that seems quite slow! What if you move it on the GPU? |
Sorry @simone-silvestri for the late reply. I am happy to try it again on a GPU but last time there was an error. I can try it again and let you know what the error is. |
@simone-silvestri
|
I stand corrected, there is more information. To me this actually looks very different even.
|
Can you make an MWE for this and open an issue? |
I will certainly give it a try and see what part of it is causing the issue. This will likely take me a day or two to get to. |
@simone-silvestri , I realize it's been a few months but I am still keen to this this example up and running. I can try this all again this week but if you had time to meet for an hour, I wonder if that would help? |
Sure, I ll text on slack. |
Sure, I can reduce the restoring rate and sponge region and output once every 5 days |
I have reduced a bit the restoring rate, reduced the extend of the northern sponge region, and changed the output writer schedule to 5 days |
Thanks @simone-silvestri . I just updated my repo and will run it right away. I hope to have some results by tomorrow, maybe. |
When I tried running it I got an error. Maybe this is related to other updates?
|
Yeah, see #318 (comment), CliMA/Oceananigans.jl#4037, CliMA/Oceananigans.jl#4036 We need to fix it! |
Thanks @navidcy for pointing this out. I will look to see if there is a bandaide fix in the mean time. |
CliMA/Oceananigans.jl#4036 (comment) as bandaid 🩹? |
I think we need to update Climaocean to Oceananigans version 0.95.6 to make sure the GPUArrays that comes with it is correct |
Thanks @navidcy for pointing this out. I tried the example and can get the same error, but I don't see the fix anywhere in the comment. Is there an easy temporary fix? |
I presume we still need another patch before we can move forward with this example? |
@simone-silvestri , can we chat about this sometime? |
Sure, do you want me to update the example with the current syntax in the meantime? |
Yes, please! When do you have time to talk? |
Sure, do you want to zoom today? (I am on central european time so now it would be great) |
Would noon Boston time work for you? I can also do earlier or later if you prefer. |
Purpose
Following up on #106, this is a first attempt to create a regional model with ECCO-derived restoring at the boundaries. We decided to try focusing on the ACC in the southern ocean.
To-do
It does not run yet, but after it does, it would be good to know if people agree this is a good example to include. If yes, then we need to turn this into an example.
Content
This is the only file that is different from main at the moment.
https://github.com/CliMA/ClimaOcean.jl/blob/fjp/acc_regional_model/examples/acc_regional_simulation.jl