feat: Add configurable Android dependency versions #28

yasicmd · 2025-08-04T10:46:00Z

This PR solves issue #26 by allowing users to override the media3Version from 1.1.1 to 1.4.1 via app.json configuration, resolving Kotlin compilation errors when using CleverTap with react-native-video.

Add DependencyVersions interface for Android dependency overrides
Implement deep merge logic for user configuration with defaults
Add smart plugin directory detection for local development scenarios
Create comprehensive documentation with examples and troubleshooting
Add TypeScript support with full IntelliSense

Features:

Override any Android dependency version via app.json
Backwards compatible - existing configurations continue to work
Type-safe configuration with validation

Benefits:

Resolve Android dependency version conflicts with other packages
Future-proof version management without plugin updates
Comprehensive testing across multiple override scenarios

Note: iOS version overrides have known limitations (documented in README)

- Add DependencyVersions interface for Android dependency overrides - Implement deep merge logic for user configuration with defaults - Add smart plugin directory detection for local development scenarios - Create comprehensive documentation with examples and troubleshooting - Add TypeScript support with full IntelliSense Features: - Override any Android dependency version via app.json - Backwards compatible - existing configurations continue to work - Type-safe configuration with validation Benefits: - Resolve Android dependency version conflicts with other packages - Future-proof version management without plugin updates - Comprehensive testing across multiple override scenarios Note: iOS version overrides have known limitations (documented in README)

francispereira · 2025-08-04T10:46:08Z

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

✅ license/snyk check is complete. No issues have been found. (View Details)

✅ code/snyk check is complete. No issues have been found. (View Details)

piyush-kukadiya · 2025-10-14T09:44:27Z

src/android_config/gradle/withClevertapAndroidAppBuildGradle.ts

+        return defaults;
+    }
+
+    return {


@yasicmd Can you make this function dynamics, for example

function mergeDependencyVersions(defaults: Dependencies, overrides?: DependencyVersions): Dependencies { if (!overrides) { return defaults; } const result = {} as Dependencies; // Iterate through all keys in defaults for (const key in defaults) { result[key] = { ...defaults[key], ...(overrides[key] || {}) }; } return result; }

piyush-kukadiya · 2025-10-14T09:47:15Z

src/android_config/gradle/withClevertapAndroidAppBuildGradle.ts


-        const versionProperties = createVersionProperties(CLEVERTAP_DEPENDENCIES_DEFAULT_VERSIONS);
+        // Merge user dependency version overrides with defaults
+        const mergedVersions = mergeDependencyVersions(CLEVERTAP_DEPENDENCIES_DEFAULT_VERSIONS, dependencyVersions);


@yasicmd avoid merging if dependencyVersions is not passed by user

piyush-kukadiya · 2025-10-14T10:02:00Z

README.md

 - **Media Support:**
 Enable `android.features.enableMediaForInAppsInbox` for video content in in-app messages and app inbox.

+## 🚧 Known Limitations


@yasicmd Remove this section.

piyush-kukadiya · 2025-10-14T10:03:10Z

README.md

+
+The CleverTap Expo Plugin supports overriding Android dependency versions and iOS constants directly from your `app.json`, solving compatibility issues and providing version control flexibility.
+
+### Key Benefits


@yasicmd Remove key benefits section.

piyush-kukadiya · 2025-10-14T10:04:13Z

README.md

 | iOS.notifications.iosPushAppGroup | string | This value should be set to to enable logging Push Impressions to dashboard. The user profile details should be saved in specified "app group". When push notification is received, the saved profile details will be used to log Push Impression to correct profile. | Default is null. (Should be set to log Push Impressions) |
+| iOS.versions | IOSVersions | Optional. Override iOS constants like deployment target, device family, and bundle versions. See [Dependency Versions Guide](docs/DEPENDENCY_VERSIONS.md) for detailed configuration. | Default uses plugin-defined constants. |

+## 🔧 Configurable Dependency Versions


@yasicmd Keep the formatting same, use #### Heading level 4

piyush-kukadiya · 2025-10-14T10:12:11Z

docs/DEPENDENCY_VERSIONS.md

+
+The CleverTap Expo Plugin supports configurable dependency versions, allowing you to override any Android dependency version or iOS constant from your `app.json` configuration. This feature solves compatibility issues between CleverTap and other packages and provides complete control over dependency versions.
+
+## Current Status


@yasicmd Delete text from Line 7 to Line 24

piyush-kukadiya · 2025-10-14T10:14:13Z

docs/DEPENDENCY_VERSIONS.md

+|----------|---------------|-------------|
+| `googleAdId.playServicesAdsVersion` | `18.2.0` | Google Play Services Ads Identifier version |
+
+### Tested Examples


@yasicmd Delete text from Line 116 to Line 160

piyush-kukadiya · 2025-10-14T10:52:11Z

docs/DEPENDENCY_VERSIONS.md

+3. **No Action Required**: The plugin includes fallback logic for local development
+4. **Extensions Created**: iOS extensions should still be created successfully despite the different path resolution
+
+### Common Error Messages


@yasicmd Delete text from Line 346 to Line 479

piyush-kukadiya

Left few comments. Also raise PR to develop branch.

Sonal-Kachare · 2025-10-15T16:00:55Z

src/iOS_config/withCleverTapNotificationContentExtension.ts

            // await nseUpdater.updateNSEEntitlements(`group.${config.ios?.bundleIdentifier}.clevertap`)
-            await nseUpdater.updateNEBundleVersion(config.ios?.buildNumber ?? DEFAULT_BUNDLE_VERSION);
-            await nseUpdater.updateNEBundleShortVersion(config?.version ?? DEFAULT_BUNDLE_SHORT_VERSION);
+            await nseUpdater.updateNEBundleVersion(config.ios?.buildNumber ?? getDefaultBundleVersion(clevertapProps.ios?.versions?.defaultBundleVersion));


@yasicmd I tested the logic, but doesn't work fine if I don't provide config.version or config.ios?.buildNumber values

jbagaresgaray · 2025-10-18T09:41:30Z

Any updates of this?

This was referenced Aug 4, 2025

Fix react-native-video compatibility by updating media3Version to 1.4.1 #27

Closed

Media3 version compatibility issue with react-native-video causing Android build failures #26

Closed

piyush-kukadiya reviewed Oct 14, 2025

View reviewed changes

piyush-kukadiya requested changes Oct 14, 2025

View reviewed changes

Sonal-Kachare reviewed Oct 15, 2025

View reviewed changes


		The CleverTap Expo Plugin supports overriding Android dependency versions and iOS constants directly from your `app.json`, solving compatibility issues and providing version control flexibility.

		### Key Benefits


		The CleverTap Expo Plugin supports configurable dependency versions, allowing you to override any Android dependency version or iOS constant from your `app.json` configuration. This feature solves compatibility issues between CleverTap and other packages and provides complete control over dependency versions.

		## Current Status

feat: Add configurable Android dependency versions #28

Are you sure you want to change the base?

feat: Add configurable Android dependency versions #28

Uh oh!

Conversation

yasicmd commented Aug 4, 2025

Uh oh!

francispereira commented Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎉 Snyk checks have passed. No issues have been found so far.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

piyush-kukadiya left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jbagaresgaray commented Oct 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

francispereira commented Aug 4, 2025 •

edited

Loading