Citizen sync #253
Draft
Citizen sync #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o external-mods-api
…o external-mods-api
Moved Command and Handler to the API package. Command handlers are now done for all packages not just CSM ones.
not needed
Static classes are nasty!
Moving CommandReflectionHelper utils into ReflectionHelper. Removing static from IgnoreHelper.
This reverts commit f13b918.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt at #69
This is built on top of #235 to try and prevent more issues after the code structure was changed.
Once mod support get's merged I'll rebase this one and the changes that don't belong to it will be removed.
Help and opinions on how to accomplish this are welcomed.