Fix Secure Internet Gateway Feature Template Attachment Failure #533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Oct 1, 2025
danischm
approved these changes
Oct 9, 2025
seconroy
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the #202 and #527 issues with Secure Internet Gateway Feature Template. In particular:
servicesandtrackerssection: if attribute order is incorrect, the template configuration is successful but push of template to the device fails as described in secure_internet_gateway_feature_template update fails with vManage error #202pre-shared-secret,ike-local-id,ike-remote-idin payload by removingexclude_ignore: truein generator: without this change, the template configuration via TF works, but template cannot be opened in the UI (stuck in permanent loading screen as described in SIG Feature Template generated using Terraform is missing Certain JSON Fields #527)priority_order_alwaysparameter to the feature template generator and configures it for secure internet gatewayservicesandtrackers: this feature template requires priority-order to be always included in the payload and current generator was conditional on optional parameter value. Seems like this is something unique to this feature template so additional parameter was added not to impact the existing logic.notIgnorevalues toshutdownandmtuparameters (this converts toBody to manual).This also fixes #534 that addresses same problems as in SIG with priority_order_always.