Skip to content
This repository was archived by the owner on Feb 25, 2020. It is now read-only.

Update README.md #102

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update README.md #102

wants to merge 1 commit into from

Conversation

coquer
Copy link

@coquer coquer commented Jun 6, 2017

No description provided.

@ghost
Copy link

ghost commented Sep 25, 2017

I think it should be.

'Zipper'  => Chumper\Zipper\Facades\Zipper::class,

Otherwise it is just an alias to the Chumper\Zipper\Zipper not the Facade and therefore not using the Service Provider

johannesschobel
johannesschobel suggested changes Apr 15, 2018
View reviewed changes
Copy link

@johannesschobel johannesschobel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add the alias to the facade and not the class directly

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@johannesschobel johannesschobel johannesschobel requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@coquer @johannesschobel