Prevent crash in agent_proxmox_ve special agent when backup log fetch fails #864
+11
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The agent_proxmox_ve special agent was crashing whenever backup logs were fetched via fetch_backup_data() due to unhandled errors, causing the entire agent to fail. To fix this, I wrapped the fetch_backup_data() call in a try/except block. Now, if an error occurs (such as API failures or data inconsistencies), the agent logs a warning and continues gracefully by using an empty result for backup logs instead of crashing. This change improves the overall stability and reliability of the agent, ensuring that it still provides other monitoring data even if some backup log retrievals fail. Additionally, the internal logic processes backup logs per VM, so individual VM failures do not affect the entire data set.