Skip to content

Add check_disk_smb results handling #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add check_disk_smb results handling #848

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions cmk/plugins/smb/lib/check_disk_smb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,10 @@ def _extract_data_from_not_matching_lines(
ErrorResult(state=2, summary='Connection to 192.168.0.11 failed')
>>> _extract_data_from_not_matching_lines(["tree connect failed: NT_STATUS_BAD_NETWORK_NAME"], "hostname", "share")
ErrorResult(state=2, summary='Invalid share name \\\\\\\\hostname\\\\share')
>>> _extract_data_from_not_matching_lines(["session setup failed: NT_STATUS_NO_LOGON_SERVERS"], "hostname", "share")
ErrorResult(state=2, summary='No logon server')
>>> _extract_data_from_not_matching_lines(["session setup failed: NT_STATUS_IO_TIMEOUT"], "hostname", "share")
ErrorResult(state=2, summary='Timeout')
>>> _extract_data_from_not_matching_lines(["some other error"], "hostname", "share")
ErrorResult(state=3, summary='Result from smbclient not suitable')
"""
Expand All @@ -331,6 +335,14 @@ def _extract_data_from_not_matching_lines(
if re.search(r"(You specified an invalid share name|NT_STATUS_BAD_NETWORK_NAME)", line):
return ErrorResult(2, f"Invalid share name \\\\{hostname}\\{share}")

# no logon server
if re.search(r"(No logon servers|NT_STATUS_NO_LOGON_SERVERS)", line):
return ErrorResult(2, "No logon server")

# time out
if re.search(r"(Timeout|NT_STATUS_IO_TIMEOUT)", line):
return ErrorResult(2, "Timeout")

return ErrorResult(state, summary)


Expand Down