Fix ups checks with Python ValueError exceptions #837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This error https://github.com/Checkmk/checkmk/actions/runs/16622749658/job/47030993204?pr=837#step:7:347 is not related to my changes. Can you support? I do not know, what I can do, to solve it. Thank you |
sven-ruess
force-pushed
the
ups-fix
branch
3 times, most recently
from
efa259e to
dc59177
Compare
Signed-off-by: Sven Rueß <[email protected]>
|
Hi Sven! |
|
Hi Moritz, I contacted the customer to provide me a snmpwalk. After I have received, I will forward it. Further I can tell you, that the problem is, that some values have not value and are None. Conversion from None to int is not working. So I take care about, that all needed values will be int. If present, the current value, otherwise 0. Functions are working as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General information
Checkmk 2.4.0p7 is used on Checkmk appliance 1.7.10.
ups check voltage in, ups voltage out and ups load out were not working and break down with exception ValueError.
Bug reports
If a ups device configured and a discovery is done, then those checks will report this exception.
Proposed changes
Take care about the value, which should be used for the check. In all cases a integer is return and check is working.