Skip to content

Conversation

felixjogris
Copy link
Contributor

General information

This aligns check_mk_agent with the filesystem hierarchy found on FreeBSD.

Proposed changes

On FreeBSD, check_mk_agent is not part of the base system, but installed via ports or (pre-compiled) packages. Configuration files for these 3rd party applications are expected in /usr/local/etc.
Also, FreeBSD has no /var/lib, but /var/db.

Copy link

github-actions bot commented Aug 8, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@felixjogris
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA or my organization already has a signed CLA.

@felixjogris
Copy link
Contributor Author

recheck

@NikCheckmk
Copy link

Hi @felixjogris, thanks a lot for your contribution.

As accepting your change would probably come with some migration effort, could you please explain what makes these changes necessary? Does it lead to concrete problems with your monitoring? Or is it only about complying to standards?

Many thanks in advance!

@felixjogris
Copy link
Contributor Author

Hi @NikCheckmk ,

solely to comply with the FreeBSD filesystem hierarchy. Please see https://docs.freebsd.org/en/books/handbook/basics/#dirstructure or https://man.freebsd.org/cgi/man.cgi?query=hier&sektion=7:

  • /usr/local: "local executables, libraries, etc, installed by pkg(7) or ports(7)"
  • /var/lib: "state information for ported Linux applications"

One might argue about /var/lib but I believe that a monitoring agent shouldn't count as "ported application".
Ports on FreeBSD already patch this (please see https://github.com/freebsd/freebsd-ports/blob/main/net-mgmt/check_mk_agent/Makefile#L56). Thus, I expect no impact for users, just a small change for the ports/package maintainer.

Best regards,
Felix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants