refactor: run_js_test_file in integration tests #752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rework the helper to return `Result<Vec<String>, RunFailure>`, which makes it more ergonomic to handle run errors in tests expecting the run to succeed. Signed-off-by: Miroslav Bajtoš <[email protected]>
This was referenced Apr 24, 2025
pyropy
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework the helper
run_js_test_file()to returnResult<Vec<String>, RunFailure>, which makes it more ergonomic to handle run errors in tests expecting the run to succeed.This is a follow-up for the discussion we had in #740 (comment)