-
Notifications
You must be signed in to change notification settings - Fork 2
docs: verify that Linux release artifacts run in Docker #747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Miroslav Bajtoš <[email protected]>
Signed-off-by: Miroslav Bajtoš <[email protected]>
Signed-off-by: Miroslav Bajtoš <[email protected]>
Signed-off-by: Miroslav Bajtoš <[email protected]>
@@ -35,3 +35,42 @@ refer to `X.Y.Z` as _major_, _minor_ and _patch_ version. | |||
changes. | |||
|
|||
1. Click on the green button `Publish release` | |||
|
|||
## Testing the release build pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this already part of CI? Or is this something we're expected to perform manually before publishing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great question!
This is not part of CI, we're expected to perform this manually when making changes to the release build pipeline (the GitHub Actions workflow).
I.e. this is a manual check to verify that the release build pipeline works as expected.
Do you think it's worth automating this check and running it for every release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine to keep it manual, but can you please document that this is to be performed when working on the pipeline? That wasn't clear to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ie "testing the release build pipeline" could also mean it's something you're supposed to do after every release, to verify the release build pipeline worked
Capturing the comment #172 (comment)
Related to: