Skip to content

docs: verify that Linux release artifacts run in Docker #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

bajtos
Copy link
Member

@bajtos bajtos commented Apr 23, 2025

bajtos added 2 commits April 23, 2025 12:44
Signed-off-by: Miroslav Bajtoš <[email protected]>
Signed-off-by: Miroslav Bajtoš <[email protected]>
@bajtos bajtos requested a review from juliangruber April 23, 2025 11:06
@bajtos bajtos changed the title docs: verify Linux release artifacts run in Docker docs: verify that Linux release artifacts run in Docker Apr 23, 2025
Signed-off-by: Miroslav Bajtoš <[email protected]>
@@ -35,3 +35,42 @@ refer to `X.Y.Z` as _major_, _minor_ and _patch_ version.
changes.

1. Click on the green button `Publish release`

## Testing the release build pipeline
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this already part of CI? Or is this something we're expected to perform manually before publishing?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great question!

This is not part of CI, we're expected to perform this manually when making changes to the release build pipeline (the GitHub Actions workflow).

I.e. this is a manual check to verify that the release build pipeline works as expected.

Do you think it's worth automating this check and running it for every release?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to keep it manual, but can you please document that this is to be performed when working on the pipeline? That wasn't clear to me

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ie "testing the release build pipeline" could also mean it's something you're supposed to do after every release, to verify the release build pipeline worked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants