Skip to content

Fix jagged lines sticking out from behind data point circles #5031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix jagged lines sticking out from behind data point circles #5031

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
852a6e2
better
gsbernstein Mar 23, 2023
d2901b8
exclude stepping (always 90)
gsbernstein Mar 23, 2023
aecb0cb
shared variable
gsbernstein Mar 23, 2023
1486809
name
gsbernstein Mar 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Source/Charts/Renderers/LineChartRenderer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,6 +396,8 @@ open class LineChartRenderer: LineRadarRenderer
}

var firstPoint = true

let shouldDisconnectSegments = dataSet.drawCirclesEnabled && !isDrawSteppedEnabled

let path = CGMutablePath()
for x in stride(from: _xBounds.min, through: _xBounds.range + _xBounds.min, by: 1)
Expand All @@ -409,9 +411,12 @@ open class LineChartRenderer: LineRadarRenderer
y: CGFloat(e1.y * phaseY))
.applying(valueToPixelMatrix)

if firstPoint || shouldDisconnectSegments {
path.move(to: startPoint)
}

if firstPoint
{
path.move(to: startPoint)
firstPoint = false
}
else
Expand Down