Skip to content

fix: allow multicodecs override #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: allow multicodecs override #517

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,8 @@ export class GossipSub extends TypedEventEmitter<GossipsubEvents> implements Pub
* The signature policy to follow by default
*/
public readonly globalSignaturePolicy: typeof StrictSign | typeof StrictNoSign
public multicodecs: string[] = [constants.GossipsubIDv12, constants.GossipsubIDv11, constants.GossipsubIDv10]

public multicodecs: string[]

private publishConfig: PublishConfig | undefined

Expand Down Expand Up @@ -501,6 +502,8 @@ export class GossipSub extends TypedEventEmitter<GossipsubEvents> implements Pub

this.globalSignaturePolicy = opts.globalSignaturePolicy ?? StrictSign

this.multicodecs = options.multicodecs ?? [constants.GossipsubIDv12, constants.GossipsubIDv11, constants.GossipsubIDv10]

// Also wants to get notified of peers connected using floodsub
if (opts.fallbackToFloodsub) {
this.multicodecs.push(constants.FloodsubID)
Expand Down Expand Up @@ -2849,7 +2852,6 @@ export class GossipSub extends TypedEventEmitter<GossipsubEvents> implements Pub
const peerStreams = this.streamsOutbound.get(id)
if (
(peerStreams != null) &&
this.multicodecs.includes(peerStreams.protocol) &&
!peers.has(id) &&
!this.direct.has(id)
) {
Expand Down Expand Up @@ -3059,7 +3061,6 @@ export class GossipSub extends TypedEventEmitter<GossipsubEvents> implements Pub
const peerStreams = this.streamsOutbound.get(id)
if (
(peerStreams != null) &&
this.multicodecs.includes(peerStreams.protocol) &&
!fanoutPeers.has(id) &&
!this.direct.has(id)
) {
Expand Down Expand Up @@ -3123,7 +3124,7 @@ export class GossipSub extends TypedEventEmitter<GossipsubEvents> implements Pub
if (peerStreams == null) {
return
}
if (this.multicodecs.includes(peerStreams.protocol) && filter(id)) {
if (filter(id)) {
peers.push(id)
}
})
Expand Down