Fix/padid init order #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

winshaurya wants to merge 2 commits into Cerebras:main from winshaurya:fix/padid-init-order

+11 −7

winshaurya commented Sep 29, 2025

solved #64

nice repo file structure , btw heres what i did

fix pad_id assignment order in finetuningtokengenerator
assign pad_id before usage in eos_token initialization
resolves AttributeError when eos_id is None
improves constructor reliability and code clarity
ready for merge, tested and error-free

winshaurya added 2 commits

September 29, 2025 17:29


          fix: add missing import os to vae_hf_cs.py

df967dc


          fix pad_id assignment order in finetuningtokengenerator

3aa9993

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet