export and import focus points #213
Merged
+136
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces functionality to export and import focus points to CSV files, along with related UI changes.
- Added export and import buttons to the point control section and connected their signals.
- Implemented export_focus_points and import_focus_points methods with CSV-based data persistence.
- Modified status label handling and adjusted some UI text and layout details.
Comments suppressed due to low confidence (1)
software/control/widgets.py:5705
- Verify that the unit for the Z coordinate in the CSV header matches the unit used in the focus points data, as X and Y are in mm.
writer.writerow(["Region_ID", "X_mm", "Y_mm", "Z_um"])
| y = float(row[y_idx]) | ||
| z = float(row[z_idx]) | ||
| imported_points.append((region_id, x, y, z)) | ||
| except (ValueError, IndexError): |
There was a problem hiding this comment.
[nitpick] Consider logging a warning when a row conversion fails in the import process to help diagnose data issues instead of silently continuing.
Suggested change
| except (ValueError, IndexError): | |
| except (ValueError, IndexError) as e: | |
| logging.warning(f"Failed to convert row {row}: {e}") |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export focus points to CSV files and import