[ENG-8513] No DB transaction Notifications #11252
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/feature/osfgroup [ENG-7934] OSF Notifications Refactor
…/feature/ENG-7908-remove-meetings-comments-and-osf-groups-notifications [ENG-7908] Remove Meetings, Comments and OSF Groups Notifications
…cience/osf.io into add-new-notifications-data-model * 'feature/pbs-25-10' of https://github.com/CenterForOpenScience/osf.io: [ENG-7965] Add v2 email token confirmation endpoints (CenterForOpenScience#11139)
…cience/osf.io into add-new-notifications-data-model * 'feature/pbs-25-10' of https://github.com/CenterForOpenScience/osf.io: fix issue where not having any external identities caused a 500
…cience/osf.io into add-new-notifications-data-model * 'feature/pbs-25-10' of https://github.com/CenterForOpenScience/osf.io: [ENG-7966] Add "collected-in" relationship for Nodes (CenterForOpenScience#11140)
…cience/osf.io into refactor-notifications * 'feature/pbs-25-10' of https://github.com/CenterForOpenScience/osf.io: fix issue where trying another already confirmed email threw an uncaught exception (CenterForOpenScience#11161) [ENG-8148] Add ArtifactOutcome in annotations to linked nodes (CenterForOpenScience#11158) [ENG-7966] Add "collected-in" relationship for Nodes (CenterForOpenScience#11140) fix issue where not having any external identities caused a 500 [ENG-7965] Add v2 email token confirmation endpoints (CenterForOpenScience#11139) [ENG-8052] Fixed FilterMixin issue with multiple values of notification subscription field (CenterForOpenScience#11150) support related_counts for view_only links (CenterForOpenScience#11148) allow admins change registration providers (CenterForOpenScience#11145) [ENG-7927] Improved logging for embargo termination (CenterForOpenScience#11137) [ENG-7873] CLONE - SPAM - When Hamming a Spammed user, preprints and registrations remain private (CenterForOpenScience#11125) Update changelog and package.json fix TypeError when check stucked registration revert async email sending (CenterForOpenScience#11134) [ENG-7921] Add scopes for applications to full_read and full_write scopes (CenterForOpenScience#11126) # Conflicts: # api_tests/nodes/views/test_node_detail.py # api_tests/nodes/views/test_node_linked_registrations.py # framework/auth/oauth_scopes.py # tests/test_registrations/test_retractions.py
…OpenScience/osf.io into feature/notification-refactor-phase-1 * 'refactor-notifications' of https://github.com/CenterForOpenScience/osf.io: Clean up tests Clean up tests Clean up imports Remove Meetings, Comments and OSF Groups Notifications remove osf groups remove osf groups remove osf groups remove osf groups remove osf groups # Conflicts: # api_tests/nodes/views/test_node_detail.py # api_tests/nodes/views/test_node_linked_registrations.py # framework/auth/oauth_scopes.py # tests/test_registrations/test_retractions.py
…hub.com/bodintsov/osf.io into feature/notification-refactor-phase-1 * 'feature/remove-remaining-quickiles-code' of https://github.com/bodintsov/osf.io: flake8 fixed tests remove quickfiles
…ap-Zherebetskyi/osf.io into feature/notification-refactor-phase-1 * 'feature/remove_test_speed-up' of https://github.com/Ostap-Zherebetskyi/osf.io: update mails mock Update send_mail mocks
…re/notification-refactor-phase-1 Update Notification Refactor to Phase 1
…cience/osf.io into add-new-notifications-data-model * 'feature/pbs-25-10' of https://github.com/CenterForOpenScience/osf.io: fix issue where trying another already confirmed email threw an uncaught exception (CenterForOpenScience#11161) [ENG-8148] Add ArtifactOutcome in annotations to linked nodes (CenterForOpenScience#11158)
…OpenScience/osf.io into add-new-notifications-data-model * 'refactor-notifications' of https://github.com/CenterForOpenScience/osf.io: flake8 fixed tests remove quickfiles update mails mock Update send_mail mocks Clean up tests Clean up tests Clean up imports Remove Meetings, Comments and OSF Groups Notifications remove osf groups remove osf groups remove osf groups remove osf groups remove osf groups # Conflicts: # tests/test_notifications.py
…OpenScience/osf.io into refactor-notifications * 'refactor-notifications' of https://github.com/CenterForOpenScience/osf.io: flake8 fixed tests remove quickfiles update mails mock Update send_mail mocks # Conflicts: # tests/test_registrations/test_retractions.py
…rForOpenScience#11245) * fixed earlier version download the newest version file * fixed tests
* create monthly reports when institution is created * better exception handling; async generate report * fix test * handle deactivated institutions; minor fixes
…OpenScience/osf.io into refactor-notifications * 'refactor-notifications' of https://github.com/CenterForOpenScience/osf.io: remove logs groups embedding
…cience/osf.io into add-new-notifications-data-model * 'feature/pbs-25-13' of https://github.com/CenterForOpenScience/osf.io: (35 commits) [ENG-8462] Institution setup fixes (CenterForOpenScience#11241) [ENG-8401] Earlier preprint versions download the current file (CenterForOpenScience#11245) added academiaInstitution in social-schema, fixed True value of 'ongoing', fixed/added tests (CenterForOpenScience#11239) [ENG-7979] Registrations pending moderation that have components also pending moderation do not display the children (CenterForOpenScience#11222) [ENG-8216] Fixed children deletion on a node page in admin (CenterForOpenScience#11237) [ENG-8401] Fixed preprint downloading (CenterForOpenScience#11238) fix categories for sendgrid emails (CenterForOpenScience#11236) [ENG-8936] API: Allow /v2/users/me/preprints list view to filter by tags (CenterForOpenScience#11232) Add collections scopes to FULL_READ and FULL_WRITE add brand relationship to collectionprovider [ENG-8224] Fixed force archive template with registration addons (CenterForOpenScience#11210) API: Allow /v2/users/me/preprints list view to filter by title [ENG-8325] Public column does not display the visibility status of child nodes on the Nodes page in the Admin App [ENG-8246] Fixed deletion of maintenance alerts in admin (CenterForOpenScience#11226) add exception handling to /review_actions/ endpoint added a route to download node metadata (CenterForOpenScience#11215) [ENG-7929] Ability to move registrations to draft state (CenterForOpenScience#11153) switch to new UI when user views draft registration file (CenterForOpenScience#11144) [ENG-5862] SPAM - Fix Wiki Spamming (CenterForOpenScience#11171) improved displaying of stashed urls and approval state in admin (CenterForOpenScience#11193) ... # Conflicts: # admin/nodes/views.py # api_tests/users/views/test_user_settings_detail.py # framework/email/tasks.py # tests/framework_tests/test_email.py # tests/test_user_profile_view.py
…etordoff/osf.io into add-new-notifications-data-model * 'feature/digest_notifications_update' of github.com:johnetordoff/osf.io: Add notification digest unit tests fix mail mocking issues for password reset mock mail for tests re-expose quickfiles migrated logs review comments remove logs groups embedding remove logs groups embedding digest notifications update Add is_digest flag to notification subscriptions and related notifications # Conflicts: # admin/nodes/views.py # api_tests/users/views/test_user_settings_detail.py # framework/email/tasks.py # osf/email/__init__.py # osf/models/notification_type.py # tests/framework_tests/test_email.py # tests/test_user_profile_view.py # website/notifications/emails.py # website/notifications/listeners.py
…OpenScience/osf.io into add-new-notifications-data-model * 'refactor-notifications' of https://github.com/CenterForOpenScience/osf.io: fix mail mocking issues for password reset mock mail for tests re-expose quickfiles migrated logs remove logs groups embedding remove logs groups embedding
…p-Zherebetskyi/osf.io into add-new-notifications-data-model * 'feature/notifications_admin' of https://github.com/Ostap-Zherebetskyi/osf.io: fix unit tests fix unit tests add notifications admin and unit tests # Conflicts: # api_tests/users/views/test_user_settings.py # api_tests/users/views/test_user_settings_reset_password.py
Johnetordoff
force-pushed
the
refactor-notifications
branch
3 times, most recently
from
a66ed0f to
30c13ab
Compare
Johnetordoff
force-pushed
the
refactor-notifications
branch
4 times, most recently
from
e2a16ac to
a2dd86a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
No DB transaction Notifications
Changes
Cache the id of the NotificationType instance, you need, so you can access the correct email template
create a save parameter to the emit methods and make it default to True, to preserve the existing behavior, however setting save to False should circumvent creating a notification or subscription object and just send the message.
QA Notes
N/A
Documentation
N/A
Side Effects
N/A
Ticket
https://openscience.atlassian.net/browse/ENG-8513