[ENG-8400] Feature/notification metrics #11240
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/feature/osfgroup [ENG-7934] OSF Notifications Refactor
…/feature/ENG-7908-remove-meetings-comments-and-osf-groups-notifications [ENG-7908] Remove Meetings, Comments and OSF Groups Notifications
…cience/osf.io into add-new-notifications-data-model * 'feature/pbs-25-10' of https://github.com/CenterForOpenScience/osf.io: [ENG-7965] Add v2 email token confirmation endpoints (CenterForOpenScience#11139)
…cience/osf.io into add-new-notifications-data-model * 'feature/pbs-25-10' of https://github.com/CenterForOpenScience/osf.io: fix issue where not having any external identities caused a 500
…cience/osf.io into add-new-notifications-data-model * 'feature/pbs-25-10' of https://github.com/CenterForOpenScience/osf.io: [ENG-7966] Add "collected-in" relationship for Nodes (CenterForOpenScience#11140)
…cience/osf.io into refactor-notifications * 'feature/pbs-25-10' of https://github.com/CenterForOpenScience/osf.io: fix issue where trying another already confirmed email threw an uncaught exception (CenterForOpenScience#11161) [ENG-8148] Add ArtifactOutcome in annotations to linked nodes (CenterForOpenScience#11158) [ENG-7966] Add "collected-in" relationship for Nodes (CenterForOpenScience#11140) fix issue where not having any external identities caused a 500 [ENG-7965] Add v2 email token confirmation endpoints (CenterForOpenScience#11139) [ENG-8052] Fixed FilterMixin issue with multiple values of notification subscription field (CenterForOpenScience#11150) support related_counts for view_only links (CenterForOpenScience#11148) allow admins change registration providers (CenterForOpenScience#11145) [ENG-7927] Improved logging for embargo termination (CenterForOpenScience#11137) [ENG-7873] CLONE - SPAM - When Hamming a Spammed user, preprints and registrations remain private (CenterForOpenScience#11125) Update changelog and package.json fix TypeError when check stucked registration revert async email sending (CenterForOpenScience#11134) [ENG-7921] Add scopes for applications to full_read and full_write scopes (CenterForOpenScience#11126) # Conflicts: # api_tests/nodes/views/test_node_detail.py # api_tests/nodes/views/test_node_linked_registrations.py # framework/auth/oauth_scopes.py # tests/test_registrations/test_retractions.py
…OpenScience/osf.io into feature/notification-refactor-phase-1 * 'refactor-notifications' of https://github.com/CenterForOpenScience/osf.io: Clean up tests Clean up tests Clean up imports Remove Meetings, Comments and OSF Groups Notifications remove osf groups remove osf groups remove osf groups remove osf groups remove osf groups # Conflicts: # api_tests/nodes/views/test_node_detail.py # api_tests/nodes/views/test_node_linked_registrations.py # framework/auth/oauth_scopes.py # tests/test_registrations/test_retractions.py
…hub.com/bodintsov/osf.io into feature/notification-refactor-phase-1 * 'feature/remove-remaining-quickiles-code' of https://github.com/bodintsov/osf.io: flake8 fixed tests remove quickfiles
…ap-Zherebetskyi/osf.io into feature/notification-refactor-phase-1 * 'feature/remove_test_speed-up' of https://github.com/Ostap-Zherebetskyi/osf.io: update mails mock Update send_mail mocks
…re/notification-refactor-phase-1 Update Notification Refactor to Phase 1
…cience/osf.io into add-new-notifications-data-model * 'feature/pbs-25-10' of https://github.com/CenterForOpenScience/osf.io: fix issue where trying another already confirmed email threw an uncaught exception (CenterForOpenScience#11161) [ENG-8148] Add ArtifactOutcome in annotations to linked nodes (CenterForOpenScience#11158)
…OpenScience/osf.io into add-new-notifications-data-model * 'refactor-notifications' of https://github.com/CenterForOpenScience/osf.io: flake8 fixed tests remove quickfiles update mails mock Update send_mail mocks Clean up tests Clean up tests Clean up imports Remove Meetings, Comments and OSF Groups Notifications remove osf groups remove osf groups remove osf groups remove osf groups remove osf groups # Conflicts: # tests/test_notifications.py
…OpenScience/osf.io into refactor-notifications * 'refactor-notifications' of https://github.com/CenterForOpenScience/osf.io: flake8 fixed tests remove quickfiles update mails mock Update send_mail mocks # Conflicts: # tests/test_registrations/test_retractions.py
Johnetordoff
requested changes
Jul 25, 2025
There was a problem hiding this comment.
This is a good set-up for future reports. I'd like if you added some unittests, they don't have to have too many cases, but it should assert for at least one of the report metrics now, just to have working tests ready when we get better details about what we are aggregating.
admin/base/settings/defaults.py
Outdated
| @@ -40,7 +40,8 @@ | |||
| CSRF_COOKIE_HTTPONLY = False | |||
|
|
|||
| ALLOWED_HOSTS = [ | |||
| '.osf.io' | |||
| '.osf.io', | |||
| 'localhost' | |||
There was a problem hiding this comment.
Take this out, you can override this in the local.py or add it to the local-dist.py, but not in this file.
There was a problem hiding this comment.
have got it there by mistake, have already removed
Johnetordoff
force-pushed
the
refactor-notifications
branch
7 times, most recently
from
e2a16ac to
a2dd86a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add backend for the Notifications metrics report
Changes
TBD
QA Notes
TBD
Documentation
TBD
Side Effects
TBD
Ticket
https://openscience.atlassian.net/browse/ENG-8400