Skip to content

Conversation

futa-ikeda
Copy link
Contributor

@futa-ikeda futa-ikeda commented Aug 7, 2025

Purpose

  • Implement FE support for new Redirect service types in GravyValet

Summary of Changes

  • Add new external-redirect-service model
  • Update user-addons-manager and addons-service-manager to support new addon type
  • Update UI for redirect services
    • User Addons page:
      • "Connected Accounts" tab is disabled when looking at redirect services
      • Terms page is updated to show new message when selecting a redirect service
      • Clicking on "Go to DataPipe" button will open a new window where users can configure their account
    • Node Addons page:
      • Terms page is updated to show new message when selecting a redirect service
      • New window appears with ?nodeIri= query-param to allow service side to know what node the request came from

Screenshot(s)

Node addons page:
image

Clicking into DataPipe to view the terms page and pop-up window where users can set up their DataPipe account (note the nodeIri queryparam in the popup URL):
image

User addons page:
image
Terms page with pop-up window for setting up DataPipe account:
image

Side Effects

QA Notes

@coveralls
Copy link

coveralls commented Aug 8, 2025

Pull Request Test Coverage Report for Build 17079697876

Details

  • 7 of 35 (20.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 67.103%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/osf-components/addon/components/addons-service/manager/component.ts 2 13 15.38%
lib/osf-components/addon/components/addons-service/user-addons-manager/component.ts 5 22 22.73%
Totals Coverage Status
Change from base Build 16993843233: -0.1%
Covered Lines: 8559
Relevant Lines: 12286

💛 - Coveralls

@futa-ikeda futa-ikeda changed the title WIP redirect service [ENG-8326] Redirect service support Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants