Ensure the unaccent normalizer sanitizes the query term post normalization
#559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The full list can be seen in `/usr/share/postgresql/tsearch_data/unaccent.rules` from Postgres
SQL unaccent may introduce single quotes from different unicode amended formatted characters, We need to re-sanitize the string after we executed unaccent.
|
Hi @nertzy , what do you think of those changes? I've extended the tests to add a few more characters that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an sql string is fed to
to_tsquery, postgres functions get executed prior to string conversion to tsquery.unaccentfunction may create unexpected single quote symbols, that will lead to "invalid tsquery" error from Postgres.Wrap the
unaccentoutput inregexp_replace, to make sure the query term is properly sanitized post normalization.Related to #487 #558