Added nau7802 odr as kconfig option #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linguini1
requested changes
Jul 8, 2025
|
|
||
| config SENSORS_NAU7802_ODR | ||
| int "NAU7802 ODR" | ||
| default 0 |
There was a problem hiding this comment.
Add a range keyword to help limit to 0-7
| priv->lower.type = SENSOR_TYPE_FORCE; | ||
| priv->enabled = false; | ||
| priv->odr = NAU7802_ODR_10HZ; /* 10Hz (0.1s) default ODR */ | ||
| priv->odr = CONFIG_SENSORS_NAU7802_ODR; |
There was a problem hiding this comment.
When the sensor boots, is it's default 10Hz? Because if so, you'll need to make sure that a user ODR of a different value is set on the chip, not just stored in the struct.
Also, make this configurable via the uORB interface for setting sampling frequency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Kconfig option for the ODR was added for on the fly configuration of the system
Impact
You can now change the ODR on the nau7802
Testing