Fix for syslogging error when building with sim #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #86 .
The issue was with an undefined macro that's caused when "Enable Syslog Output" isn't enabled in
make menuconfig. A simple fix here just checks if the macro is defined or not, and if not, it skips syslog setup.An alternative or additional solution to this PR would be to make
INSPACE_TELEMdepend onCONFIG_INSPACE_SYSLOG_OUTPUTwhich would ensure the macro is defined however, if we want to be able to disable the syslog output, then this PR alone should be good.This PR has been tested on Josh, and I have heard the startup sound.