Skip to content

Fix memory leak of CADisplayLink. #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix memory leak of CADisplayLink. #70

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions CircleProgressView/CircleProgressView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,22 @@ import UIKit
self.addSubview(contentView)
}

open override func willMove(toSuperview newSuperview: UIView?) {
if newSuperview == nil {
displayLink?.invalidate()
displayLink = nil
}
super.willMove(toSuperview: newSuperview)
}

open override func willMove(toWindow newWindow: UIWindow?) {
if newWindow == nil {
displayLink?.invalidate()
displayLink = nil
}
super.willMove(toSuperview: newWindow)
}

@objc func internalInit() {
let displayLink = CADisplayLink(target: self, selector: #selector(CircleProgressView.displayLinkTick))
displayLink.add(to: RunLoop.main, forMode: .defaultRunLoopMode)
Expand Down