Skip to content

feat: update to webpack4+ #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: update to webpack4+ #25

wants to merge 1 commit into from

Conversation

HOUCe
Copy link

@HOUCe HOUCe commented Dec 5, 2018

In webpack 4, Tapable#apply and Tapable#plugin raise a deprecation notice.

  • Tapable#apply(plugin) must be replaced by a call to plugin.apply
  • Tapable#plugin(hook, fn) must be replaced by a call to hook.tap (or hook.tapAsync)

Note: This is breaking change because it drops webpack < 4 compatibility.

For more info:

  • Highly suggest to refractor with Target design which uses webpack native plugins such as JsonpTemplatePlugin. This leads to incompatibility with lower webpack version.
  • Update wxapp-boilerplate needed.
  • webpack4+ does not support node <= 4, need to delete Travis CI test version.

@HOUCe HOUCe force-pushed the dev branch 4 times, most recently from 8420756 to ddbfbcc Compare December 5, 2018 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants