- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 393
Consolidate Gaussian1 functors #1951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3055e4c    to
    9c156b3      
    Compare
  
    | Sample runners are failing due to Cantera/cantera-example-data#3. Otherwise, this is ready for a review. | 
9c156b3    to
    b9e1791      
    Compare
  
    | Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@            Coverage Diff             @@
##             main    #1951      +/-   ##
==========================================
+ Coverage   74.97%   74.98%   +0.01%     
==========================================
  Files         450      450              
  Lines       56241    56241              
  Branches     9300     9300              
==========================================
+ Hits        42168    42174       +6     
+ Misses      10939    10933       -6     
  Partials     3134     3134              ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
 | 
2af024e    to
    1b54800      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For these two existing examples, it would be helpful to add redirects for these names to the .htaccess files in the cantera-website repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 ... see Cantera/cantera-website#276
1b54800    to
    3083431      
    Compare
  
    3083431    to
    dc0df98      
    Compare
  
    | @speth ... sorry to dismiss your review, but I decided to test the new  | 
dc0df98    to
    9702119      
    Compare
  
    Submodule uses kebab-case rather than snake_case for consistency.
9702119    to
    865ef16      
    Compare
  
    | @speth ... the  | 
Changes proposed in this pull request
Gaussian1functors instead of Python implementations in samples and testsnanosecond-pulse-discharge.pysamplePorousMediaBurner.pyandNonIdealShockTube.pysamplesIf applicable, fill in the issue number this pull request is fixing
Closes #1950
Checklist
scons build&scons test) and unit tests address code coverage