Skip to content

Conversation

@ischoegl
Copy link
Member

@ischoegl ischoegl commented Aug 23, 2025

Changes proposed in this pull request

  • Use C++ Gaussian1 functors instead of Python implementations in samples and tests
  • Use underscores rather than the unpythonic hyphens ("kebab-case") in the new nanosecond-pulse-discharge.py sample
  • Use snake_case rather than the unpythonic CamelCase for PorousMediaBurner.py and NonIdealShockTube.py samples

If applicable, fill in the issue number this pull request is fixing

Closes #1950

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@ischoegl
Copy link
Member Author

Sample runners are failing due to Cantera/cantera-example-data#3. Otherwise, this is ready for a review.

@ischoegl ischoegl marked this pull request as ready for review August 23, 2025 14:34
@ischoegl ischoegl requested a review from a team August 23, 2025 14:35
@ischoegl ischoegl force-pushed the consolidate-gaussians branch from 9c156b3 to b9e1791 Compare August 23, 2025 14:39
@codecov
Copy link

codecov bot commented Aug 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.98%. Comparing base (3375822) to head (970fb1e).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1951      +/-   ##
==========================================
+ Coverage   74.97%   74.98%   +0.01%     
==========================================
  Files         450      450              
  Lines       56241    56241              
  Branches     9300     9300              
==========================================
+ Hits        42168    42174       +6     
+ Misses      10939    10933       -6     
  Partials     3134     3134              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ischoegl ischoegl force-pushed the consolidate-gaussians branch 2 times, most recently from 2af024e to 1b54800 Compare August 23, 2025 18:07
speth
speth previously approved these changes Aug 23, 2025
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For these two existing examples, it would be helpful to add redirects for these names to the .htaccess files in the cantera-website repository.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ischoegl ischoegl force-pushed the consolidate-gaussians branch from 3083431 to dc0df98 Compare August 23, 2025 18:56
@ischoegl
Copy link
Member Author

ischoegl commented Aug 23, 2025

@speth ... sorry to dismiss your review, but I decided to test the new example-data procedure (while also addressing the license issue). The merge sequence would thus be:

  1. Clarify readme (Cantera/cantera#1951) cantera-example-data#5
  2. this PR
  3. Update snake_case Python sample redirects cantera-website#276

Submodule uses kebab-case rather than snake_case for consistency.
@ischoegl ischoegl force-pushed the consolidate-gaussians branch from 9702119 to 865ef16 Compare August 24, 2025 00:47
@ischoegl ischoegl requested a review from speth August 24, 2025 02:09
@ischoegl
Copy link
Member Author

@speth ... the example_data submodule is reset.

@speth speth merged commit 794cc53 into Cantera:main Aug 25, 2025
50 of 51 checks passed
@ischoegl ischoegl deleted the consolidate-gaussians branch October 19, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consolidate use of Gaussians

2 participants