Update intercom.module.ts: Angular10 #104
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding <Type> to ModuleWithProviders as required in Angular 10
|
"test-deploy" fail because it couldn't install "npm-wee". Really need that update to keep using "ng-intercom" after upgrading my apps ton Angular10. Thanks a lot |
|
i've pushed new code to update that. please merge in master and check if your PR passes. thanks, and sorry for the delay |
|
it did not fix it. npm-install-wee is just npm install, some dependencies are out of date. can you update them in your pr? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding to ModuleWithProviders as required in Angular 10
Summary of changes:
Intended/example use case:
Checklist:
npm run buildruns without errorng servespawns app, Intercom messenger is visible and interactive, and there are no errors in the consoleCloses issue: #