Skip to content

Add 'register' method to VertexSerializerRegistry #1924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Add 'register' method to VertexSerializerRegistry #1924

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/api/java/net/caffeinemc/mods/sodium/api/vertex/serializer/VertexSerializerRegistry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,6 @@ static VertexSerializerRegistry instance() {
}

VertexSerializer get(VertexFormatDescription srcFormat, VertexFormatDescription dstFormat);

void register(VertexFormatDescription srcFormat, VertexFormatDescription dstFormat, VertexSerializer serializer);
}
21 changes: 21 additions & 0 deletions ...jellysquid/mods/sodium/client/render/vertex/serializers/VertexSerializerRegistryImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,27 @@ public VertexSerializer get(VertexFormatDescription srcFormat, VertexFormatDescr
return serializer;
}

@Override
public void register(VertexFormatDescription srcFormat, VertexFormatDescription dstFormat, VertexSerializer serializer) {
var identifier = createKey(srcFormat, dstFormat);

if (this.cache.containsKey(identifier)) {
throw new IllegalArgumentException("Serializer already exists for the given vertex formats: " + srcFormat + " -> " + dstFormat);
}

if (serializer == null) {
throw new NullPointerException("Serializer parameter is null.");
}

var stamp = this.lock.writeLock();

try {
this.cache.put(identifier, serializer);
} finally {
this.lock.unlockWrite(stamp);
}
}

private VertexSerializer create(long identifier, VertexFormatDescription srcFormat, VertexFormatDescription dstFormat) {
var serializer = createSerializer(srcFormat, dstFormat);
var stamp = this.lock.writeLock();
Expand Down