Pysat pb reification optimisation #783
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbierlee
reviewed
Oct 31, 2025
Contributor
There was a problem hiding this comment.
This can actually be made into a mergeable PR with the following trick: expect this assertion (using with pytest.raises(..), see doc) to raise an AssertionError (as it currently would). This passes. Once pypblib is updated and on our end upgraded, this test fails, and can be update the test. Maybe over-engineered, but avoids needing to remember this PR forever.
[edit: so that's only about the bit that tests the new expected output from pypblib. Indeed, the PySAT one is blocking for this PR, so we'll have to wait. The code looks good.]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is such that conditionals can natively be added when using pysat to translate PB constraints.
The PR depends on two other PRs, one in pysat itself pysathq/pysat#206 which adds this functionality within pysat and another one in PBLIB rjungbeck/pypblib#6, which cleans up some trivial constraints. The latter one is not a blocker, it's just a testcase that would need to be changed.