Skip to content

CSOC-WEEK3-VUE completed #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

AnantJain05
Copy link

@AnantJain05 AnantJain05 commented Jun 26, 2022

Repo
Deployment

  • Auth Middleware
  • Login Function
  • Add task
  • Get tasks
  • Update Task
  • Delete Task

Copy link
Collaborator

@tiger-yash tiger-yash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Implementation!

Expected Improvements:

  • UI should have been improved (buttons and logout).
  • No additional feature added.

})
.then(() => {
this.$toast.success('Todo deleted successfully')
this.todos = this.todos.filter((todo) => todo.id !== _id)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could have used splice

@@ -2,6 +2,7 @@
<aside class="mx-auto flex justify-between mt-24 px-4">
<label for="add task" class="flex-1">
<input
v-model="newTask"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no .trim on data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants