Skip to content

PLT-212 CDAP workflow for tofu format and lint #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

PLT-212 CDAP workflow for tofu format and lint #320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
4de4b22
add tofu format workflow
Sep 30, 2025
91d9121
add tofu format workflow
Sep 30, 2025
05eb9d4
add tofu format workflow
Sep 30, 2025
7271b79
Add tofu-format-and-validate-diff script
gsf Oct 6, 2025
565a68c
Rewrite tofu-format-and-validate workflow
gsf Oct 6, 2025
393d11b
Clarify directory skipping
gsf Oct 6, 2025
7d78508
Rename to tofu-checks
gsf Oct 15, 2025
6cc0120
Rename step in tofu-checks
gsf Oct 15, 2025
668fc11
Drop workflow_run triggers
gsf Oct 15, 2025
32fcadc
Merge branch 'main' into PLT-212
gsf Oct 15, 2025
0baf2f8
Ref commit hash for checkout in tofu-checks
gsf Oct 15, 2025
32696f4
Add python-checks
gsf Oct 15, 2025
1aad852
Drop pylint and pytest from tf-alarm-to-slack
gsf Oct 15, 2025
69d23ca
Drop terraform lock in api-waf-sync
gsf Oct 15, 2025
970cc5e
Drop whitespace in tf-security-groups
gsf Oct 15, 2025
7833b75
Add tofu-plan workflow
gsf Oct 15, 2025
99d670a
Add todo to alarm-to-slack
gsf Oct 15, 2025
e2da6e5
Add all_services input on tofu-plan
gsf Oct 17, 2025
30c93e2
Fetch all history for tofu-checks and tofu-plan to allow git diff
gsf Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .github/workflows/python-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
name: python-checks

on:
push:
paths:
- terraform/services/alarm-to-slack/lambda_src/**
workflow_dispatch:

jobs:
python-checks:
runs-on: codebuild-cdap-${{github.run_id}}-${{github.run_attempt}}
steps:
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
- run: scripts/python-checks
9 changes: 0 additions & 9 deletions .github/workflows/tf-admin-aco-deny.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,7 @@ defaults:
working-directory: ./terraform/services/admin-aco-deny

jobs:
check-fmt:
runs-on: codebuild-cdap-${{github.run_id}}-${{github.run_attempt}}
steps:
- uses: actions/checkout@v4
- uses: sigstore/cosign-installer@d58896d6a1865668819e1d91763c7751a165e159 # v3.9.2
- uses: cmsgov/cdap/actions/setup-tenv@8343fb96563ce4b74c4dececee9b268f42bd4a40
- run: tofu fmt -check -diff -recursive .

plan-apply:
needs: check-fmt
permissions:
contents: read
id-token: write
Expand Down
9 changes: 0 additions & 9 deletions .github/workflows/tf-admin-create-aco-creds.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,7 @@ defaults:
working-directory: ./terraform/services/admin-create-aco-creds

jobs:
check-fmt:
runs-on: codebuild-cdap-${{github.run_id}}-${{github.run_attempt}}
steps:
- uses: actions/checkout@v4
- uses: sigstore/cosign-installer@d58896d6a1865668819e1d91763c7751a165e159 # v3.9.2
- uses: cmsgov/cdap/actions/setup-tenv@8343fb96563ce4b74c4dececee9b268f42bd4a40
- run: tofu fmt -check -diff -recursive .

plan-apply:
needs: check-fmt
permissions:
contents: read
id-token: write
Expand Down
9 changes: 0 additions & 9 deletions .github/workflows/tf-admin-create-aco.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,7 @@ defaults:
working-directory: ./terraform/services/admin-create-aco

jobs:
check-fmt:
runs-on: codebuild-cdap-${{github.run_id}}-${{github.run_attempt}}
steps:
- uses: actions/checkout@v4
- uses: sigstore/cosign-installer@d58896d6a1865668819e1d91763c7751a165e159 # v3.9.2
- uses: cmsgov/cdap/actions/setup-tenv@8343fb96563ce4b74c4dececee9b268f42bd4a40
- run: tofu fmt -check -diff -recursive .

plan-apply:
needs: check-fmt
permissions:
contents: read
id-token: write
Expand Down
9 changes: 0 additions & 9 deletions .github/workflows/tf-admin-create-group.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,7 @@ defaults:
working-directory: ./terraform/services/admin-create-group

jobs:
check-fmt:
runs-on: codebuild-cdap-${{github.run_id}}-${{github.run_attempt}}
steps:
- uses: actions/checkout@v4
- uses: sigstore/cosign-installer@d58896d6a1865668819e1d91763c7751a165e159 # v3.9.2
- uses: cmsgov/cdap/actions/setup-tenv@8343fb96563ce4b74c4dececee9b268f42bd4a40
- run: tofu fmt -check -diff -recursive .

plan-apply:
needs: check-fmt
permissions:
contents: read
id-token: write
Expand Down
20 changes: 0 additions & 20 deletions .github/workflows/tf-alarm-to-slack.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,27 +28,7 @@ defaults:
working-directory: ./terraform/services/alarm-to-slack

jobs:
python-lint-test:
runs-on: codebuild-cdap-${{github.run_id}}-${{github.run_attempt}}
steps:
- uses: actions/checkout@v4
- name: Install Python dependencies & Run Lint and Unit Tests
run: |
pip install pylint pytest
pylint lambda_src
pytest lambda_src

check-fmt:
needs: python-lint-test
runs-on: codebuild-cdap-${{github.run_id}}-${{github.run_attempt}}
steps:
- uses: actions/checkout@v4
- uses: sigstore/cosign-installer@d58896d6a1865668819e1d91763c7751a165e159 # v3.9.2
- uses: cmsgov/cdap/actions/setup-tenv@8343fb96563ce4b74c4dececee9b268f42bd4a40
- run: tofu fmt -check -diff -recursive .

plan-apply-deploy:
needs: check-fmt
permissions:
contents: read
id-token: write
Expand Down
9 changes: 0 additions & 9 deletions .github/workflows/tf-api-waf-sync.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,7 @@ defaults:
working-directory: ./terraform/services/api-waf-sync

jobs:
check-fmt:
runs-on: codebuild-cdap-${{github.run_id}}-${{github.run_attempt}}
steps:
- uses: actions/checkout@v4
- uses: sigstore/cosign-installer@d58896d6a1865668819e1d91763c7751a165e159 # v3.9.2
- uses: cmsgov/cdap/actions/setup-tenv@8343fb96563ce4b74c4dececee9b268f42bd4a40
- run: tofu fmt -check -diff -recursive .

plan-apply:
needs: check-fmt
permissions:
contents: read
id-token: write
Expand Down
9 changes: 0 additions & 9 deletions .github/workflows/tf-api-waf.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,16 +23,7 @@ defaults:
working-directory: ./terraform/services/api-waf

jobs:
check-fmt:
runs-on: codebuild-cdap-${{github.run_id}}-${{github.run_attempt}}
steps:
- uses: actions/checkout@v4
- uses: sigstore/cosign-installer@d58896d6a1865668819e1d91763c7751a165e159 # v3.9.2
- uses: cmsgov/cdap/actions/setup-tenv@8343fb96563ce4b74c4dececee9b268f42bd4a40
- run: tofu fmt -check -diff -recursive .

plan-apply:
needs: check-fmt
permissions:
contents: read
id-token: write
Expand Down
9 changes: 0 additions & 9 deletions .github/workflows/tf-backup-plan.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,16 +23,7 @@ defaults:
working-directory: ./terraform/services/backup-plan

jobs:
check-fmt:
runs-on: codebuild-cdap-${{github.run_id}}-${{github.run_attempt}}
steps:
- uses: actions/checkout@v4
- uses: sigstore/cosign-installer@d58896d6a1865668819e1d91763c7751a165e159 # v3.9.2
- uses: cmsgov/cdap/actions/setup-tenv@8343fb96563ce4b74c4dececee9b268f42bd4a40
- run: tofu fmt -check -diff -recursive .

plan-apply:
needs: check-fmt
permissions:
contents: read
id-token: write
Expand Down
9 changes: 0 additions & 9 deletions .github/workflows/tf-bucket-access-logs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,16 +22,7 @@ defaults:
working-directory: ./terraform/services/bucket-access-logs

jobs:
check-fmt:
runs-on: codebuild-cdap-${{github.run_id}}-${{github.run_attempt}}
steps:
- uses: actions/checkout@v4
- uses: sigstore/cosign-installer@d58896d6a1865668819e1d91763c7751a165e159 # v3.9.2
- uses: cmsgov/cdap/actions/setup-tenv@8343fb96563ce4b74c4dececee9b268f42bd4a40
- run: tofu fmt -check -diff -recursive .

plan-apply:
needs: check-fmt
permissions:
contents: read
id-token: write
Expand Down
9 changes: 0 additions & 9 deletions .github/workflows/tf-cclf-import.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,7 @@ defaults:
working-directory: ./terraform/services/cclf-import

jobs:
check-fmt:
runs-on: codebuild-cdap-${{github.run_id}}-${{github.run_attempt}}
steps:
- uses: actions/checkout@v4
- uses: sigstore/cosign-installer@d58896d6a1865668819e1d91763c7751a165e159 # v3.9.2
- uses: cmsgov/cdap/actions/setup-tenv@8343fb96563ce4b74c4dececee9b268f42bd4a40
- run: tofu fmt -check -diff -recursive .

plan-apply:
needs: check-fmt
permissions:
contents: read
id-token: write
Expand Down
9 changes: 0 additions & 9 deletions .github/workflows/tf-codebuild-projects.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,16 +20,7 @@ defaults:
working-directory: ./terraform/services/codebuild-projects

jobs:
check-fmt:
runs-on: codebuild-cdap-${{github.run_id}}-${{github.run_attempt}}
steps:
- uses: actions/checkout@v4
- uses: sigstore/cosign-installer@d58896d6a1865668819e1d91763c7751a165e159 # v3.9.2
- uses: cmsgov/cdap/actions/setup-tenv@8343fb96563ce4b74c4dececee9b268f42bd4a40
- run: tofu fmt -check -diff -recursive .

plan-apply:
needs: check-fmt
permissions:
contents: read
id-token: write
Expand Down
9 changes: 0 additions & 9 deletions .github/workflows/tf-external-services-ip-sets.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,16 +22,7 @@ defaults:
working-directory: ./terraform/services/external-services-ip-sets

jobs:
check-fmt:
runs-on: codebuild-cdap-${{github.run_id}}-${{github.run_attempt}}
steps:
- uses: actions/checkout@v4
- uses: sigstore/cosign-installer@d58896d6a1865668819e1d91763c7751a165e159 # v3.9.2
- uses: cmsgov/cdap/actions/setup-tenv@8343fb96563ce4b74c4dececee9b268f42bd4a40
- run: tofu fmt -check -diff -recursive .

plan-apply:
needs: check-fmt
permissions:
contents: read
id-token: write
Expand Down
9 changes: 0 additions & 9 deletions .github/workflows/tf-github-actions-oidc-provider.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,16 +23,7 @@ defaults:
working-directory: ./terraform/services/github-actions-oidc-provider

jobs:
check-fmt:
runs-on: codebuild-cdap-${{github.run_id}}-${{github.run_attempt}}
steps:
- uses: actions/checkout@v4
- uses: sigstore/cosign-installer@d58896d6a1865668819e1d91763c7751a165e159 # v3.9.2
- uses: cmsgov/cdap/actions/setup-tenv@8343fb96563ce4b74c4dececee9b268f42bd4a40
- run: tofu fmt -check -diff -recursive .

plan-apply:
needs: check-fmt
permissions:
contents: read
id-token: write
Expand Down
9 changes: 0 additions & 9 deletions .github/workflows/tf-github-actions-role.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,16 +22,7 @@ defaults:
working-directory: ./terraform/services/github-actions-role

jobs:
check-fmt:
runs-on: codebuild-cdap-${{github.run_id}}-${{github.run_attempt}}
steps:
- uses: actions/checkout@v4
- uses: sigstore/cosign-installer@d58896d6a1865668819e1d91763c7751a165e159 # v3.9.2
- uses: cmsgov/cdap/actions/setup-tenv@8343fb96563ce4b74c4dececee9b268f42bd4a40
- run: tofu fmt -check -diff -recursive .

plan-apply:
needs: check-fmt
permissions:
contents: read
id-token: write
Expand Down
9 changes: 0 additions & 9 deletions .github/workflows/tf-kms-keys.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,16 +23,7 @@ defaults:
working-directory: ./terraform/services/kms-keys

jobs:
check-fmt:
runs-on: codebuild-cdap-${{github.run_id}}-${{github.run_attempt}}
steps:
- uses: actions/checkout@v4
- uses: sigstore/cosign-installer@d58896d6a1865668819e1d91763c7751a165e159 # v3.9.2
- uses: cmsgov/cdap/actions/setup-tenv@8343fb96563ce4b74c4dececee9b268f42bd4a40
- run: tofu fmt -check -diff -recursive .

plan-apply:
needs: check-fmt
permissions:
contents: read
id-token: write
Expand Down
9 changes: 0 additions & 9 deletions .github/workflows/tf-opt-out-export.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,7 @@ defaults:
working-directory: ./terraform/services/opt-out-export

jobs:
check-fmt:
runs-on: codebuild-cdap-${{github.run_id}}-${{github.run_attempt}}
steps:
- uses: actions/checkout@v4
- uses: sigstore/cosign-installer@d58896d6a1865668819e1d91763c7751a165e159 # v3.9.2
- uses: cmsgov/cdap/actions/setup-tenv@8343fb96563ce4b74c4dececee9b268f42bd4a40
- run: tofu fmt -check -diff -recursive .

plan-apply:
needs: check-fmt
permissions:
contents: read
id-token: write
Expand Down
9 changes: 0 additions & 9 deletions .github/workflows/tf-opt-out-import.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,7 @@ defaults:
working-directory: ./terraform/services/opt-out-import

jobs:
check-fmt:
runs-on: codebuild-cdap-${{github.run_id}}-${{github.run_attempt}}
steps:
- uses: actions/checkout@v4
- uses: sigstore/cosign-installer@d58896d6a1865668819e1d91763c7751a165e159 # v3.9.2
- uses: cmsgov/cdap/actions/setup-tenv@8343fb96563ce4b74c4dececee9b268f42bd4a40
- run: tofu fmt -check -diff -recursive .

plan-apply:
needs: check-fmt
permissions:
contents: read
id-token: write
Expand Down
11 changes: 1 addition & 10 deletions .github/workflows/tf-security-groups.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,19 +20,10 @@ env:

defaults:
run:
working-directory: ./terraform/services/security-groups
working-directory: ./terraform/services/security-groups

jobs:
check-fmt:
runs-on: codebuild-cdap-${{github.run_id}}-${{github.run_attempt}}
steps:
- uses: actions/checkout@v4
- uses: sigstore/cosign-installer@d58896d6a1865668819e1d91763c7751a165e159 # v3.9.2
- uses: cmsgov/cdap/actions/setup-tenv@8343fb96563ce4b74c4dececee9b268f42bd4a40
- run: tofu fmt -check -diff -recursive .

plan-apply:
needs: check-fmt
permissions:
contents: read
id-token: write
Expand Down
9 changes: 0 additions & 9 deletions .github/workflows/tf-snyk-integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,16 +23,7 @@ defaults:
working-directory: ./terraform/services/snyk-integration

jobs:
check-fmt:
runs-on: codebuild-cdap-${{github.run_id}}-${{github.run_attempt}}
steps:
- uses: actions/checkout@v4
- uses: sigstore/cosign-installer@d58896d6a1865668819e1d91763c7751a165e159 # v3.9.2
- uses: cmsgov/cdap/actions/setup-tenv@8343fb96563ce4b74c4dececee9b268f42bd4a40
- run: tofu fmt -check -diff -recursive .

plan-apply:
needs: check-fmt
permissions:
contents: read
id-token: write
Expand Down
9 changes: 0 additions & 9 deletions .github/workflows/tf-tfstate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,16 +25,7 @@ defaults:
working-directory: ./terraform/services/tfstate

jobs:
check-fmt:
runs-on: codebuild-cdap-${{github.run_id}}-${{github.run_attempt}}
steps:
- uses: actions/checkout@v4
- uses: sigstore/cosign-installer@d58896d6a1865668819e1d91763c7751a165e159 # v3.9.2
- uses: cmsgov/cdap/actions/setup-tenv@8343fb96563ce4b74c4dececee9b268f42bd4a40
- run: tofu fmt -check -diff -recursive .

plan-apply:
needs: check-fmt
permissions:
contents: read
id-token: write
Expand Down
26 changes: 26 additions & 0 deletions .github/workflows/tofu-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
name: tofu-checks

on:
workflow_dispatch:
pull_request:
paths:
- 'terraform/**'
push:
branches:
- main
paths:
- 'terraform/**'

env:
TENV_GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

jobs:
check:
runs-on: codebuild-cdap-${{github.run_id}}-${{github.run_attempt}}
steps:
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
fetch-depth: 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why fetch-depth: 0 instead of 1? Does zero fetch everything?

- uses: sigstore/cosign-installer@d58896d6a1865668819e1d91763c7751a165e159 # v3.9.2
- uses: cmsgov/cdap/actions/setup-tenv@8343fb96563ce4b74c4dececee9b268f42bd4a40
- run: scripts/tofu-checks
Loading
Loading