Skip to content

Conversation

@JFU-NAVA-PBC
Copy link
Contributor

@JFU-NAVA-PBC JFU-NAVA-PBC commented Apr 14, 2025

JIRA Ticket:
BB2-3798
BB2-3802

Make necessary change to sample app to use SMART App v2 scopes.

What Does This PR Do?

Make necessary change to sample app to use SMART App v2 scopes.
(Append query parameter: scope=) to the authorize URL

What Should Reviewers Watch For?

  1. Verify the sample app works as expected
  2. Access token's scopes are SMART App v2 format

Validation

  1. Checkout this PR to local
  2. Configure the sample app as instructed by README: point to your app on SBX or TEST, note you need to add v2 scopes to your app (currently this is done through Django admin 'My application' view
  3. Start the sample app (docker compose up)
  4. Going through the authorization flow (medicare.gov login with synthetic user, grant data access permission e.g. share or not share demographic info etc.)
  5. Verify the access token is tied up with v2 scope vs legacy scope (this can be done by attaching to the sample app server component and put break point at the access token obtained line and exam the access token's scope
  6. OR on the bb2 server side check the access token (through django admin access token view)

server/app.py Outdated
Comment on lines 14 to 17
app = Flask(__name__)
bb = BlueButton()


Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this bit a duplicate?

@JFU-NAVA-PBC JFU-NAVA-PBC changed the title jimfuqian/BB2-3798 Node sample client use SMART App v2 scopes jimfuqian/BB2-3798 Python sample client use SMART App v2 scopes Apr 22, 2025
@jimmyfagan jimmyfagan self-assigned this Apr 28, 2025
@jimmyfagan jimmyfagan dismissed loganbertram’s stale review April 28, 2025 21:04

Logan is out of office

@JFU-NAVA-PBC
Copy link
Contributor Author

JFU-NAVA-PBC commented Apr 30, 2025

Thanks, this PR will park here then sync with master after version bumps pr merged into master and then wait on PROD's coordination (should be in master ONLY after the API side ready for v2 scope consumption)

this PR merge to master ONLY when:

  1. python SDK v2 scope PR is in master AND
  2. python SDK v2 scope changes published to PyPI

… 'click' is included in dependencies, but having module 'click' not found when start runtime, fix is hacky: just pip install it before pipenv (Pipfile.lock) install, note this happens on master.
@JFU-NAVA-PBC JFU-NAVA-PBC merged commit 5987f82 into main May 13, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants