Skip to content

Fix Tsnice calculation #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 3, 2025
Merged

Fix Tsnice calculation #542

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e9d626f
Fix Tsnice calculation
dabail10 Sep 19, 2025
1b47cf1
Fix some bug with Tsnice
dabail10 Sep 24, 2025
453743d
Add zero initialization for Tsnice in driver
dabail10 Sep 24, 2025
ba7a2d3
Fix the computation of Tsnice to be a straight line
dabail10 Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions columnphysics/icepack_therm_vertical.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,12 +375,11 @@ subroutine thermo_vertical (dt, aicen, &
einter = einter + hilyr * zqin(k)
enddo ! k

Tsnice = c0
if ((hslyr+hilyr) > puny) then
if (hilyr > puny) then
if (hslyr > puny) then
Tsnice = (hslyr*zTsn(nslyr) + hilyr*zTin(1)) / (hslyr+hilyr)
Tsnice = Tsnice + aicen*((hilyr*zTsn(nslyr) + hslyr*zTin(1)) / (hslyr+hilyr))
else
Tsnice = Tsf
Tsnice = Tsnice + aicen*Tsf
endif
endif

Expand Down
1 change: 1 addition & 0 deletions configuration/driver/icedrv_flux.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -688,6 +688,7 @@ subroutine init_history_therm
congel (:) = c0
frazil (:) = c0
snoice (:) = c0
Tsnice (:) = c0
dsnow (:) = c0
meltt (:) = c0
melts (:) = c0
Expand Down