implemented (u)lltod in assembly #637
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZERICO2005
commented
Sep 21, 2025
Comment on lines
105
to
120
| if 0 | ||
| ; inlined __lladd_1 | ||
| inc hl | ||
| add hl, de | ||
| or a, a | ||
| sbc hl, de | ||
| jr nz, __int_to_f64_shl.finish | ||
| inc de | ||
| sbc hl, de | ||
| add hl, de | ||
| jr nz, __int_to_f64_shl.finish | ||
| inc bc | ||
| jr __int_to_f64_shl.finish | ||
| else | ||
| call __lladd_1 ; round up to even | ||
| jr __int_to_f64_shl.finish |
There was a problem hiding this comment.
would it be better to call __lladd_1 or inline it here.
There was a problem hiding this comment.
I think either way is fine since __lladd_1(BC:UDE:UHL) has a well defined calling convention. Compared to other functions with inconsistent calling conventions (such as __lladd_b(BC:UDE:UHL, A) and __llmulu_b(BC:UDE:UHL, (SP))) where inlining would help prevent conflicts.
|
On the topic of raising FE_INEXACT, I think it should only be raised if |
ZERICO2005
force-pushed
the
lltod_asm
branch
from
1d1cdb8 to
7249418
Compare
ZERICO2005
temporarily deployed
to
Autotester
GitHub Actions
Inactive
ZERICO2005
temporarily deployed
to
Autotester
GitHub Actions
Inactive
ZERICO2005
temporarily deployed
to
Autotester
GitHub Actions
Inactive
ZERICO2005
temporarily deployed
to
Autotester
GitHub Actions
Inactive
ZERICO2005
temporarily deployed
to
Autotester
GitHub Actions
Inactive
ZERICO2005
temporarily deployed
to
Autotester
GitHub Actions
Inactive
ZERICO2005
temporarily deployed
to
Autotester
GitHub Actions
Inactive
ZERICO2005
temporarily deployed
to
Autotester
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
(u)lltodin assembly and optimizes(u)ltod.Since
long doublehas 53 bits of precision, 64 bit integers may be rounded.(u)lltodcan detect if rounding occurs and raiseFE_INEXACT. This can be enabled/disabled with the define__lltod_signal_FE_INEXACT := 1at the top ofltod.src. The rounding is hard coded to round-to-nearest with ties-to-even.(u)lltodcan switch between calling__lladd_1or having it inlined.