fix[smartling]: duplicate content entries handling #4169
Conversation
|
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx test @snippet/angular-17 |
❌ Failed | 4m 55s | View ↗ |
nx test @snippet/angular-17-ssr |
❌ Failed | 4m 46s | View ↗ |
nx test @snippet/svelte |
❌ Failed | 2m 57s | View ↗ |
nx test @snippet/vue |
❌ Failed | 1m 33s | View ↗ |
nx test @snippet/react |
❌ Failed | 1m 44s | View ↗ |
nx test @e2e/nuxt |
✅ Succeeded | 9m 14s | View ↗ |
nx test @e2e/qwik-city |
✅ Succeeded | 9m 23s | View ↗ |
nx test @e2e/gen1-next15-app |
✅ Succeeded | 7m 41s | View ↗ |
Additional runs (37) |
✅ Succeeded | ... | View ↗ |
☁️ Nx Cloud last updated this comment at 2025-11-04 15:15:51 UTC
| const existingEntryIds = new Set((latestDraft.data.entries || []).map((entry: any) => entry.content?.id)); | ||
|
|
||
| // Filter out content that already exists in the job | ||
| const newContent = content.filter(c => !existingEntryIds.has(c.id)); |
There was a problem hiding this comment.
❔question:
Curious Q: what happens when the smartling job is being processed and we update the content during that time ? Do we have to schedule new job ?
There was a problem hiding this comment.
That could cause issues, not handling that right now. It would be a new feature request.
| }; | ||
|
|
||
| const symbolCount = allContent.length - content.length; | ||
| const symbolCount = allContent.length - newContent.length; |
There was a problem hiding this comment.
❔question:
Won't allContent and newContent will always have same length here ?
There was a problem hiding this comment.
If you check the code above allContent is getting updated. We add symbols to it
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This reverts commit 7991879.
2 participants
Description
If we make changes to a content entry and re-add to existing job, it was adding it twice
Screenshot
If relevant, add a screenshot or two of the changes you made.
Note
Adds Core:Button text to translation extraction/application and updates Smartling job updates to skip existing entries (and duplicate symbols), plus adjusts Smartling strings link; bumps versions.
Core:ButtontextlikeTextcomponents.tsconfig.jsontypesto empty; bump version to1.1.25.@builder.io/utilsto1.1.25and bump plugin to0.0.23-9.Written by Cursor Bugbot for commit 2894710. This will update automatically on new commits. Configure here.