-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[react-native] Support for react-dom@19 #4108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: af4e2a7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
View your CI Pipeline Execution ↗ for commit af4e2a7.
☁️ Nx Cloud last updated this comment at |
On as side note, I gave react-compiler a try on our Expo app and it failed. It seems related to Builder as the In the following example {
name: "MyComponent",
component: ({ children }) => {
console.log(children[0].type)
return children
},
canHaveChildren: true,
} I will find some time for testing and maybe opening an other PR for react-compiler support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the fix @kerwanp !! LGTM.
"@builder.io/sdk-react-native": patch | ||
--- | ||
|
||
Add support for React 19 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add support for React 19 | |
Fix: Add support for React 19 by handling `findDOMNode` deprecation |
Description
In react-dom@19 the function
findDOMNode
has been removed. Instead theref
actually contains the Element.To support both 18 and 19 version we check wether
findDOMNode
is defined.