Skip to content

Parse expr and statement into CST #2695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Nov 12, 2025
Merged

Parse expr and statement into CST #2695

merged 18 commits into from
Nov 12, 2025

Conversation

@imalsogreg
Copy link
Contributor

@imalsogreg imalsogreg commented Nov 4, 2025 •
edited
Loading

  • Adds parse_expr for expressions, including a pratt parser for operators.
  • Adds parse_stmt for statements.
  • Could use more tests.
  • Fixes some clippy lint errors and a lossless encoding issue for newlines at the end of files.

@imalsogreg imalsogreg temporarily deployed to boundary-tools-dev November 4, 2025 06:42 — with GitHub Actions Inactive
@imalsogreg imalsogreg temporarily deployed to boundary-tools-dev November 4, 2025 06:42 — with GitHub Actions Inactive
@imalsogreg imalsogreg temporarily deployed to boundary-tools-dev November 4, 2025 06:42 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Nov 4, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
promptfiddle Ready Ready Preview Comment Nov 12, 2025 11:56pm

@github-actions
Copy link

github-actions bot commented Nov 4, 2025

🌿 Preview your docs: https://boundary-preview-1f223c11-7b11-4e81-b7dc-9891d84c5201.docs.buildwithfern.com

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 4, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #2695 will degrade performances by 16.79%

Comparing greg/parse-expr-and-statement (c1592b2) with hellovai/parser (e9111c5)

Summary

❌ 9 regressions
✅ 6 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Mode Benchmark BASE HEAD Change
❌ WallTime bench_incremental_add_attribute 2.9 ms 3.4 ms -12.91%
❌ WallTime bench_incremental_add_string_char 2.9 ms 3.4 ms -12.74%
❌ WallTime bench_incremental_add_user_field 2.9 ms 3.4 ms -12.72%
❌ WallTime bench_incremental_close_string 2.9 ms 3.4 ms -13.16%
❌ WallTime bench_incremental_rename_type 2.9 ms 3.4 ms -13.05%
❌ WallTime bench_scale_100_functions 2.9 ms 3.4 ms -13.57%
❌ WallTime bench_scale_deep_nesting 2.9 ms 3.5 ms -16.79%
❌ WallTime bench_empty_project 2.9 ms 3.3 ms -13.07%
❌ WallTime bench_single_simple_file 2.9 ms 3.4 ms -13.43%

@github-actions
Copy link

github-actions bot commented Nov 4, 2025

https://sage-backend-bia0khi6j-baml.vercel.app

@imalsogreg imalsogreg temporarily deployed to boundary-tools-dev November 4, 2025 18:06 — with GitHub Actions Inactive
@imalsogreg imalsogreg temporarily deployed to boundary-tools-dev November 4, 2025 18:06 — with GitHub Actions Inactive
@imalsogreg imalsogreg temporarily deployed to boundary-tools-dev November 4, 2025 18:06 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Nov 4, 2025

🌿 Preview your docs: https://boundary-preview-a01811fc-218b-48c7-a168-2157eebba21e.docs.buildwithfern.com

@github-actions
Copy link

github-actions bot commented Nov 4, 2025

https://sage-backend-k4bv6pf05-baml.vercel.app

@imalsogreg
Don't handle comments in lexer - parse them
46f82d1 
comments
@imalsogreg
add tokens for keywords
402b941
@imalsogreg
onionskin
29702a2 
slow


salsa view

rearch

salsa line-by-line

debug flashing colors

fake files

no cheating

no cheating

diff mode

diff mode

better diffs
@imalsogreg imalsogreg temporarily deployed to boundary-tools-dev November 5, 2025 22:30 — with GitHub Actions Inactive
@imalsogreg imalsogreg temporarily deployed to boundary-tools-dev November 5, 2025 22:30 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Nov 5, 2025

🌿 Preview your docs: https://boundary-preview-b7d7ccbf-df5a-439a-a781-78b4b749713c.docs.buildwithfern.com

@imalsogreg imalsogreg force-pushed the greg/parse-expr-and-statement branch from bc9f912 to 9901b50 Compare November 5, 2025 22:32
@imalsogreg imalsogreg temporarily deployed to boundary-tools-dev November 5, 2025 22:32 — with GitHub Actions Inactive
@imalsogreg imalsogreg temporarily deployed to boundary-tools-dev November 5, 2025 22:32 — with GitHub Actions Inactive
@imalsogreg imalsogreg temporarily deployed to boundary-tools-dev November 5, 2025 22:32 — with GitHub Actions Inactive
@imalsogreg imalsogreg force-pushed the greg/parse-expr-and-statement branch from 2562106 to 307a0a4 Compare November 12, 2025 23:24
@imalsogreg imalsogreg force-pushed the greg/parse-expr-and-statement branch from 307a0a4 to d1acd15 Compare November 12, 2025 23:25
@imalsogreg imalsogreg temporarily deployed to boundary-tools-dev November 12, 2025 23:25 — with GitHub Actions Inactive
@imalsogreg imalsogreg temporarily deployed to boundary-tools-dev November 12, 2025 23:25 — with GitHub Actions Inactive
@imalsogreg imalsogreg temporarily deployed to boundary-tools-dev November 12, 2025 23:25 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Nov 12, 2025

🌿 Preview your docs: https://boundary-preview-c0e721fa-9bc0-4d8c-9341-3c8ad8c7bd30.docs.buildwithfern.com

@github-actions
Copy link

github-actions bot commented Nov 12, 2025

https://sage-backend-olh4ymcbw-baml.vercel.app

@imalsogreg imalsogreg force-pushed the greg/parse-expr-and-statement branch from d1acd15 to 38688f1 Compare November 12, 2025 23:37
@imalsogreg imalsogreg temporarily deployed to boundary-tools-dev November 12, 2025 23:37 — with GitHub Actions Inactive
@imalsogreg imalsogreg temporarily deployed to boundary-tools-dev November 12, 2025 23:37 — with GitHub Actions Inactive
@imalsogreg imalsogreg temporarily deployed to boundary-tools-dev November 12, 2025 23:37 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Nov 12, 2025

🌿 Preview your docs: https://boundary-preview-135a1577-72b6-490d-9abb-65b355fadd75.docs.buildwithfern.com

@github-actions
Copy link

github-actions bot commented Nov 12, 2025

https://sage-backend-jfdhan6ir-baml.vercel.app

@imalsogreg imalsogreg force-pushed the greg/parse-expr-and-statement branch from 38688f1 to 6fee3d6 Compare November 12, 2025 23:39
@imalsogreg imalsogreg force-pushed the greg/parse-expr-and-statement branch from 6fee3d6 to c1592b2 Compare November 12, 2025 23:40
@imalsogreg imalsogreg temporarily deployed to boundary-tools-dev November 12, 2025 23:40 — with GitHub Actions Inactive
@imalsogreg imalsogreg temporarily deployed to boundary-tools-dev November 12, 2025 23:40 — with GitHub Actions Inactive
@imalsogreg imalsogreg temporarily deployed to boundary-tools-dev November 12, 2025 23:40 — with GitHub Actions Inactive
@imalsogreg imalsogreg merged commit c8f0a41 into hellovai/parser Nov 12, 2025
5 of 7 checks passed
@imalsogreg imalsogreg deleted the greg/parse-expr-and-statement branch November 12, 2025 23:40
@github-actions
Copy link

github-actions bot commented Nov 12, 2025

🌿 Preview your docs: https://boundary-preview-94e3fb4d-3b3c-4254-972f-a2f1fb7d968c.docs.buildwithfern.com

@github-actions
Copy link

github-actions bot commented Nov 12, 2025

https://sage-backend-5nxiw4sj5-baml.vercel.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@imalsogreg @antoniosarosi