-
Notifications
You must be signed in to change notification settings - Fork 3
feat: add porto and config #411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks legit, but there's a tiny thing that you may have missed.
In lib/wallets there are other config files, user can choose one or another to handle the conectivity.
Can you add Porto support to those as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds Porto wallet connector support to the application, allowing users to connect using the Porto wallet alongside existing wallet options. The implementation includes conditional enabling via environment configuration.
- Added Porto SDK dependency and import
- Created conditional initialization based on environment flag
- Updated environment configuration to support Porto enablement
Reviewed Changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/lib/wallets/connectkit.config.tsx | Added Porto import and conditional initialization |
| src/env.ts | Added PUBLIC_ENABLE_PORTO environment variable |
| package.json | Added porto dependency and updated viem/wagmi versions |
| .env.example | Added documentation for Porto configuration option |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| if (env.PUBLIC_ENABLE_PORTO) { | ||
| try { | ||
| Porto.create() | ||
| } catch (error) { | ||
| console.error('Failed to initialize Porto:', error) | ||
| } | ||
| } |
Copilot
AI
Oct 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Porto initialization is executed at module level outside of any component or function. This could cause side effects during module loading and makes the code harder to test. Consider moving this initialization inside a function or React hook where it can be properly controlled and tested.
For web3modal, it seems like deprecated. I should do it in another PR And about RainbowKit, after installing the package, It seems like something is wrong and I don't get any wallet popup instead an scroll to the bottom with some of the connectors. Maybe it requires an specific version. To change wallets, I had to:
But I've moved the porto initialization code to another file, so the other wallets can just import that file, and hopefully get porto injected. |
|

Closes #410
Description:
Added porto connector option, by injecting it as explained here. New option to opt-out it for unsupported networks.
Steps:
(Required steps to reproduce or test the fix / feature)
Type of change:
How Has This Been Tested?
Remember to check that:
Screenshots