This repository was archived by the owner on Feb 26, 2025. It is now read-only.
use all available cores in feature extraction #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #176 +/- ##
==========================================
- Coverage 73.76% 73.29% -0.48%
==========================================
Files 38 39 +1
Lines 2413 2430 +17
==========================================
+ Hits 1780 1781 +1
- Misses 633 649 +16 ☔ View full report in Codecov by Sentry. |
anilbey
commented
Apr 11, 2024
| @@ -54,20 +54,7 @@ def test_efel_strictstim(self): | |||
| } | |||
| ) | |||
|
|
|||
| self.assertEqual(self.cell.recordings[0].efeatures["Spikecount"], 0.) | |||
|
|
|||
| def test_efel_threshold(self): | |||
There was a problem hiding this comment.
duplicate of another test with the same name
There was a problem hiding this comment.
the other test has more checks
anilbey
commented
Apr 11, 2024
| self.assertEqual(recording.efeatures["Spikecount"], 0.) | ||
| self.assertLess(abs(recording.efeatures["AP1_amp"] - 66.68), 0.01) |
There was a problem hiding this comment.
this code was not getting executed for a long time. The other test was shadowing it
anilbey
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change the
Cellobject calls therecording.compute_efeaturesin parallel in theextract_efeaturesfunction.