Skip to content

feat: allow user-provided mipmaps in WASM build #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: allow user-provided mipmaps in WASM build #393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ build/
# VS project and working files
*.vcxproj.user
.vs/
.vscode/
Debug/
Release/
x64/
Expand Down
4 changes: 2 additions & 2 deletions encoder/basisu_comp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1722,7 +1722,7 @@ namespace basisu
if ((!m_params.m_hdr) && (m_params.m_source_mipmap_images.size()))
{
// User-provided mipmaps for each layer or image in the texture array.
for (uint32_t mip_index = 0; mip_index < m_params.m_source_mipmap_images[source_file_index].size(); mip_index++)
for (uint32_t mip_index = 1; mip_index < m_params.m_source_mipmap_images[source_file_index].size(); mip_index++)
{
image& mip_img = m_params.m_source_mipmap_images[source_file_index][mip_index];

Expand All @@ -1748,7 +1748,7 @@ namespace basisu
else if ((m_params.m_hdr) && (m_params.m_source_mipmap_images_hdr.size()))
{
// User-provided mipmaps for each layer or image in the texture array.
for (uint32_t mip_index = 0; mip_index < m_params.m_source_mipmap_images_hdr[source_file_index].size(); mip_index++)
for (uint32_t mip_index = 1; mip_index < m_params.m_source_mipmap_images_hdr[source_file_index].size(); mip_index++)
{
imagef& mip_img = m_params.m_source_mipmap_images_hdr[source_file_index][mip_index];

Expand Down
Loading